-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PLAT-396 postgres backup scheduler #125
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The code removed here is going to be replaced by the next commit PLAT-396
For the ofelia job to have access to postgres, it is necessary to create a network for them to communicate on... this commit subsequently introduces a new overlay network. PLAT-396
PLAT-396
PLAT-396
Redundant code PLAT-396
Since we have specified our own network for hapi-fhir-postgres-1 to join, it removed the default joining to the instant network, which resulted in the postgres replica set chronically failing since the rep set could not communicate and thus be initialized. This commit ensures that the instant network is joined by postgres-1 PLAT-396
CastelloG
reviewed
Aug 8, 2022
CastelloG
approved these changes
Aug 8, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Just one comment on the README
Co-authored-by: Castello Govender <98533703+CastelloG@users.noreply.github.com>
In a cluster, we must ensure that the ofelia-postgres-backup service exists on the same node as postgres-1, so the placement constraints for postgres-1 and ofelia-postgres-backup have been made-to-match PLAT-396
…/platform into PLAT-396-postgres-backup-scheduler
CastelloG
reviewed
Aug 11, 2022
A new way for substituting environment variables into the config.ini file is also introduced in this commit PLAT-396
PLAT-396
Added clarity for disaster recovery of progress PLAT-396
A worthwhile test for this PR is to see whether or not the postgres backups will work without ofelia being constrained to node-1 |
nour-borgi
approved these changes
Aug 16, 2022
The readme had incorrect information that has been recitifed in this commit PLAT-396
CastelloG
approved these changes
Aug 16, 2022
…om/jembi/platform into PLAT-396-postgres-backup-scheduler
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dependent PR: https://github.com/jembi/ethiopia-on-platform/pull/71