Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PLAT-396 postgres backup scheduler #125

Merged
merged 29 commits into from
Aug 17, 2022

Conversation

Mark-Labuschagne
Copy link
Contributor

nour-borgi and others added 9 commits August 4, 2022 11:51
The code removed here is going to be replaced by the next commit
PLAT-396
For the ofelia job to have access to postgres, it is necessary to create
a network for them to communicate on... this commit subsequently introduces a new
overlay network.
PLAT-396
Since we have specified our own network for hapi-fhir-postgres-1 to
join, it removed the default joining to the instant network, which
resulted in the postgres replica set chronically failing since the rep
set could not communicate and thus be initialized. This commit ensures
that the instant network is joined by postgres-1
PLAT-396
README.md Outdated Show resolved Hide resolved
Copy link
Contributor

@CastelloG CastelloG left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
Just one comment on the README

Mark-Labuschagne and others added 3 commits August 10, 2022 09:07
Co-authored-by: Castello Govender <98533703+CastelloG@users.noreply.github.com>
In a cluster, we must ensure that the ofelia-postgres-backup service
exists on the same node as postgres-1, so the placement constraints for
postgres-1 and ofelia-postgres-backup have been made-to-match
PLAT-396
…/platform into PLAT-396-postgres-backup-scheduler
README.md Outdated Show resolved Hide resolved
Mark-Labuschagne and others added 2 commits August 11, 2022 16:48
Added clarity for disaster recovery of progress
PLAT-396
@Mark-Labuschagne
Copy link
Contributor Author

A worthwhile test for this PR is to see whether or not the postgres backups will work without ofelia being constrained to node-1

@Mark-Labuschagne Mark-Labuschagne marked this pull request as draft August 16, 2022 08:28
@Mark-Labuschagne Mark-Labuschagne marked this pull request as ready for review August 16, 2022 08:28
@Mark-Labuschagne Mark-Labuschagne marked this pull request as draft August 16, 2022 08:51
@Mark-Labuschagne Mark-Labuschagne marked this pull request as ready for review August 16, 2022 08:51
@CastelloG CastelloG marked this pull request as draft August 17, 2022 10:06
@CastelloG CastelloG marked this pull request as ready for review August 17, 2022 10:06
@nour-borgi nour-borgi marked this pull request as draft August 17, 2022 10:34
@nour-borgi nour-borgi marked this pull request as ready for review August 17, 2022 10:34
@nour-borgi nour-borgi marked this pull request as draft August 17, 2022 13:55
@nour-borgi nour-borgi marked this pull request as ready for review August 17, 2022 13:56
@nour-borgi nour-borgi marked this pull request as draft August 17, 2022 14:06
@nour-borgi nour-borgi marked this pull request as ready for review August 17, 2022 14:06
@michaelloosen michaelloosen marked this pull request as draft August 17, 2022 14:51
@michaelloosen michaelloosen marked this pull request as ready for review August 17, 2022 14:51
@michaelloosen michaelloosen merged commit eab04da into main Aug 17, 2022
@michaelloosen michaelloosen deleted the PLAT-396-postgres-backup-scheduler branch August 17, 2022 15:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants