Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PLAT-704 Add singlesignout #235

Merged
merged 9 commits into from
May 23, 2023
Merged

PLAT-704 Add singlesignout #235

merged 9 commits into from
May 23, 2023

Conversation

nour-borgi
Copy link
Collaborator

Single signout with Grafana:

Logout will remove the session from keycloak

@arran-standish arran-standish marked this pull request as draft May 11, 2023 05:00
@arran-standish arran-standish marked this pull request as ready for review May 11, 2023 05:00
@nour-borgi nour-borgi changed the title PLAT-704 Add singlesignout Grafana PLAT-704 Add singlesignout May 11, 2023
arran-standish
arran-standish requested changes May 17, 2023
View reviewed changes
Copy link
Collaborator

@arran-standish arran-standish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Before merging we would probably want to update the openhim-console version to match the one that has the keycloak logout logic

@nour-borgi nour-borgi marked this pull request as draft May 23, 2023 09:44
@nour-borgi nour-borgi marked this pull request as ready for review May 23, 2023 09:52
@nour-borgi nour-borgi merged commit c9fa925 into main May 23, 2023
@nour-borgi nour-borgi deleted the PLAT-704-singlesignout-grafana branch May 23, 2023 10:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michaelloosen michaelloosen michaelloosen approved these changes

@arran-standish arran-standish arran-standish approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nour-borgi @michaelloosen @arran-standish