New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove RSS feed on Search view #572

Closed
Hoffi1 opened this Issue Jan 30, 2014 · 11 comments

Comments

Projects
None yet
3 participants
@Hoffi1
Contributor

Hoffi1 commented Jan 30, 2014

The frontend search view contains a block "alternate feed link" - what's the use-case for that?
Also there is no view.feed.php file which I think would be required than?

@JKoelman

This comment has been minimized.

Contributor

JKoelman commented Jan 30, 2014

it would be for displaying RSS but like you said the feed is missing so would say it can be removed.

@diesl

This comment has been minimized.

Contributor

diesl commented Jan 30, 2014

it would be for displaying RSS

Haha, touché 😉

I think the question was more like "Does a RSS feed on a search page make sense?"
I don't think so.

@Hoffi1

This comment has been minimized.

Contributor

Hoffi1 commented Jan 30, 2014

@diesl: 👍

@JKoelman

This comment has been minimized.

Contributor

JKoelman commented Jan 30, 2014

before doing double work:

@hoffi are you planning to remove the code?

@Hoffi1

This comment has been minimized.

Contributor

Hoffi1 commented Jan 30, 2014

Because I'm already working on all frontend views I can do that.

On which views RSS feed is useful and where nonsense?
Currently category, eventslist, venue and venues contain view.feed.php - which looks ok for me.
So on all other views I would remove a feed block if present. OK?

@JKoelman

This comment has been minimized.

Contributor

JKoelman commented Jan 30, 2014

So on all other views I would remove a feed block if present. OK?

fine with me.

@diesl

This comment has been minimized.

Contributor

diesl commented Jan 30, 2014

I think at venues it doesn't make much sense too, does it?

@ghost ghost assigned Hoffi1 Jan 30, 2014

@Hoffi1

This comment has been minimized.

Contributor

Hoffi1 commented Jan 30, 2014

Hm - I think you are right. Watching if my backyard becomes venue? Strange...

@Hoffi1

This comment has been minimized.

Contributor

Hoffi1 commented Feb 8, 2014

Is it ok if I also remove the "create event" button from search view?

Also we should think about archive button. It's not very intuitive and also it ignores search text (e.g. shows all events). But I would move this to another issue...

@JKoelman

This comment has been minimized.

Contributor

JKoelman commented Feb 9, 2014

Is it ok if I also remove the "create event" button from search view?

fine with me

@Hoffi1

This comment has been minimized.

Contributor

Hoffi1 commented Feb 9, 2014

Feed removed from search, categories, venues (incl. venues/view.feed.php), also "create event" button removed from search view. (see pull request #593)

@Hoffi1 Hoffi1 closed this Feb 9, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment