New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

recurrence: show little icon to indicate event as part of series #627

Closed
Hoffi1 opened this Issue Mar 3, 2014 · 29 comments

Comments

Projects
None yet
5 participants
@Hoffi1
Contributor

Hoffi1 commented Mar 3, 2014

Users should be able to identify events as part of a recurrence set / series.
Backend, frontend,
list views, calendar views?, event view, edit event view (with additional note)

@Hoffi1 Hoffi1 added this to the JEM 1.9.6 beta milestone Mar 3, 2014

@Hoffi1 Hoffi1 added the enhancement label Mar 3, 2014

Hoffi1 added a commit to Hoffi1/JEM-Project that referenced this issue Mar 13, 2014

show recurrence icon (frontend) (issue jemproject#627)
(new text: COM_JEM_RECURRING_EVENT, COM_JEM_RECURRING_EVENT_DESC, COM_JEM_EDITEVENT_WARN_RECURRENCE)

Hoffi1 added a commit to Hoffi1/JEM-Project that referenced this issue Mar 16, 2014

remove saved event from recurrence set or dissolve set (issue jemproj…
…ect#627)

When an event is saved it is always removed from a recurrence set.
Also a complete recurrence set is dissolved if this is the first event.

Hoffi1 added a commit to Hoffi1/JEM-Project that referenced this issue Mar 16, 2014

@jojo12

This comment has been minimized.

Contributor

jojo12 commented Mar 17, 2014

look fine (in admin now) in the commit in Hoffi1/JEM-Project

@Hoffi1

This comment has been minimized.

Contributor

Hoffi1 commented Mar 17, 2014

@jojo12: You're faster than informed. 😄

Summary of last commits:

  • recurrence icon should be shown in all relevant views on frontend and backend (not on calendars which I think is ok)
  • when event is saved (again) it's removed from recurrence set (all recurrence fields are cleared in db)
  • when first event of a recurrence set is saved (again) complete recurrence is dissolved (all recurrence fields are cleared on all events where recurrence_first_id match event's id)
    So the theory. If there is something wrong please report.

Known issues:

  • warning text could be better
  • no dedicated information if event is first one of a recurrence set
  • instead of dissolving recurrence set next event could be used as new recurrence_first_id (but difficult because recurrence params can differ, limit counter must be adjusted)
    Also if first event is deleted recurrence set should be dissolved or new first event choosen.

@Hoffi1 Hoffi1 self-assigned this Mar 17, 2014

@jojo12

This comment has been minimized.

Contributor

jojo12 commented Mar 17, 2014

@Hoffi1: sorry, quicker than allowed. thank you. will test more.

@Hoffi1

This comment has been minimized.

Contributor

Hoffi1 commented Mar 17, 2014

@jojo12: There are no speed limits - as long as a minimum of fun is present. 😉
Thanks for all your tests. 👍

Hoffi1 added a commit to Hoffi1/JEM-Project that referenced this issue Mar 21, 2014

New content plugin to dissolve recurrence
 if first event is deleted (issue jemproject#627),
add version check to package (issue jemproject#632)

Hoffi1 added a commit to Hoffi1/JEM-Project that referenced this issue Mar 22, 2014

@Hoffi1

This comment has been minimized.

Contributor

Hoffi1 commented Mar 22, 2014

Recurrence is also dissolved now when it's first event is deleted. This is handled by the new content plugin.
Also warning text is slightly improved.

@jojo12

This comment has been minimized.

Contributor

jojo12 commented Mar 22, 2014

I tested:
When you delete first event. Only the first event is dissolved (and deleted), the rest seems (with icon) to remain in serie.
When you edit/save first event, the whole serie is dissolved.
But how can I know which is the first (after having deleted the first event), it looks like the second is the first, but the results there are others.

@Hoffi1

This comment has been minimized.

Contributor

Hoffi1 commented Mar 22, 2014

@jojo12: Have you activated the new content plugin? This is currently done by package script because plugin doesn't contain a script. So if you install the plugin only you need to activate it manually..

@jojo12

This comment has been minimized.

Contributor

jojo12 commented Mar 22, 2014

@Hoffi1: yes the plugin is activated

@Hoffi1

This comment has been minimized.

Contributor

Hoffi1 commented Mar 22, 2014

Hm... I will check it on a fresh site.

@Hoffi1

This comment has been minimized.

Contributor

Hoffi1 commented Mar 22, 2014

Just for clarification: "delete" means removed from trash too. As long as event is present in db in any state recurrence is not dissolved because this event can be used to create new events.
Only if the event is removed from event table in db (by removing it from trash) recurrence would refer to an not existing event. That's why it must be dissolved.
So for test to need to first move event to Trash. Then you select status Trashed to see trashed events, select event and click Empty trash. Only then the series should be dissolved by jem content plugin.

But independently I setup a fresh site for own tests. My test phase was a bit short. 😉

@jojo12

This comment has been minimized.

Contributor

jojo12 commented Mar 22, 2014

ok, that was helpful.
when first event is moved to trash, then the serie remains. Only if you remove first event from trash too, then the whole serie is dissolved.
When first event is edited/saved, the whole serie is dissolved.
Only remaining question is: How can I know which is the first event. In db it's clear, not in backend

@Hoffi1

This comment has been minimized.

Contributor

Hoffi1 commented Mar 22, 2014

@jojo12: Yes, the question what's first event is unanswered yet.

Hoffi1 added a commit to Hoffi1/JEM-Project that referenced this issue Mar 22, 2014

@Hoffi1

This comment has been minimized.

Contributor

Hoffi1 commented Mar 22, 2014

First events of a series are now marked with a different icon and a dlightly different warning text is shown. Frontend and backend.
So it should be complete for 2.0.

@ernst67

This comment has been minimized.

Contributor

ernst67 commented Mar 22, 2014

Sounds great! How can I obtain a package for testing?

@Hoffi1

This comment has been minimized.

Contributor

Hoffi1 commented Mar 23, 2014

@ernst67: At the moment it's on my fork and I don't know how packages are made. But you could do it manually: Goto https://github.com/Hoffi1/JEM-Project/tree/feature/recurrence and click on "Download Zip". Then you must collect the things to have a package looking like our previous packages. - or you wait until I send you a package via email (after breakfast). 😉

@jojo12

This comment has been minimized.

Contributor

jojo12 commented Mar 23, 2014

@Hoff1: great, looked in frontend and backend.
I don't know, if we should mention, that there's no possibility to edit/delete a whole serie in one.

@Hoffi1

This comment has been minimized.

Contributor

Hoffi1 commented Mar 23, 2014

@jojo12: I think this should be part of Users Manual. Not so much text inside the views, please. But I wonder if I should split warning text into two parts (strong heading and normal text) to prevent html tags inside text file. I don't fear that you translate <strong> to <stark> but it would be better to have such things inside tmpl file instead of text file I think.
@ernst67: I make a package for you now. But please note there are some more tickets I would like to have included in official 1.9.6 (e.g. #628, #630)

@jojo12

This comment has been minimized.

Contributor

jojo12 commented Mar 23, 2014

@Hoffi1: Do you think, I am that stupid? :-D

Hoffi1 added a commit to Hoffi1/JEM-Project that referenced this issue Mar 23, 2014

editevent: split recurr. warning (issue jemproject#627)
split into title and text to allow formatting inside tmpl file
also both "<br>" and "\n" are possible in language file
@Hoffi1

This comment has been minimized.

Contributor

Hoffi1 commented Mar 23, 2014

As I said: I don't fear that. And in your special case I'm sure you're not! 😉
But have split it into title and text part to have more clear design. Also it's now possible to use both <br> and \n for line break. And e.g. Ä (UTF-8 encoded) and &Auml; for special characters are possible too.

Hoffi1 added a commit to Hoffi1/JEM-Project that referenced this issue Mar 29, 2014

auto-creation: set correct state on new events (issue jemproject#627)
new event is published if reference event is archived or trashed

Hoffi1 added a commit to Hoffi1/JEM-Project that referenced this issue Apr 2, 2014

@Hoffi1

This comment has been minimized.

Contributor

Hoffi1 commented Apr 3, 2014

Most things implemented and available on master yet.
open:

  • dissolve series OR take next event as reference if first event (reference) is deleted
  • when to show recurrence icon in frontend (always, never, depending on user (rights), ...)
@ernst67

This comment has been minimized.

Contributor

ernst67 commented Apr 3, 2014

I vote for:

  • take next event as reference if first event (reference) is deleted
    and
  • when to show recurrence icon in frontend : 'never', or 'make it a setting'

:-)

@Hoffi1

This comment has been minimized.

Contributor

Hoffi1 commented Apr 3, 2014

Oh, third task I forgot (no vote required 😉 )

  • show actual recurrence values in editevent views (because form fields are cleared to get new values if user want)
@Hoffi1

This comment has been minimized.

Contributor

Hoffi1 commented Apr 3, 2014

My voting for the other two:

  • leave it as is because we plan a "real" recurrence handling
  • add a global setting to always/never show icon in frontend (fast) or depending on user's rights (time-consuming)
@ernst67

This comment has been minimized.

Contributor

ernst67 commented Apr 3, 2014

OK, so you would like to delete the entire series as soon as the first one is deleted?

I guess that if you allow this from the front end, it will lead to a lot of misunderstandings.(and unhappy people, when more than one editor is added to a group)
:-/

@Hoffi1

This comment has been minimized.

Contributor

Hoffi1 commented Apr 3, 2014

Erm, do we talk about the same? When first event of a series is deleted only the series itself is dissolved. No other event is deleted. But you are right, without this series no new events are created when anticipation window moves. But this was the cause for having dedicated icon and warning text for these first events. (delete is not possible in frontend so only edit would trigger to dissolve series)

@ernst67

This comment has been minimized.

Contributor

ernst67 commented Apr 3, 2014

OK, I'm sorry. I misinterpreted. The events stay active, but are no longer part of a series, and no new events are created.
Hmmmm.. then my preference would be to allocate the next event in the row as 'first'. But I can't estimate how much work it is to create....

@Hoffi1

This comment has been minimized.

Contributor

Hoffi1 commented Apr 3, 2014

But then you will have the problem with the forgotton series ends date - you know: 365 days manually delete every day the newly created event until last valid event can be deleted. 😀

The work would be: instead of clearing recurrence fields of all relevant events find next event's id and set this id as recurrence_first_id on all relevant events - not really a challenge. 😉

Hoffi1 added a commit to Hoffi1/JEM-Project that referenced this issue Apr 6, 2014

show recurr. icon if user can edit only (issue jemproject#627)
+ fix to prevent sql error in JemUser::ismaintainer()
+ allow day and venue view to use common events table layout (but they don't yet)

In frontend views with event lists show recurrence icon on those events user is allowed to edit. So a "normal" user wouldn't see this icon somewhere, where an admin would see this icon on each recurring event.

Hoffi1 added a commit to Hoffi1/JEM-Project that referenced this issue Apr 6, 2014

jojo12 added a commit that referenced this issue Apr 6, 2014

Merge pull request #648 from Hoffi1/feature/recurr-show-as-info
show actual recurrence params in editevent views (issue #627)

@diesl diesl modified the milestones: JEM 1.9.7 beta, JEM 1.9.6 beta Apr 29, 2014

@Hoffi1

This comment has been minimized.

Contributor

Hoffi1 commented Jul 1, 2014

Is there something to do or can we live with the current implementation as is until recurrence is completely redesigned?

@JKoelman

This comment has been minimized.

Contributor

JKoelman commented Jul 1, 2014

think it's fien for the moment so let's close it.

@JKoelman JKoelman closed this Jul 1, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment