Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add abort code (J3+) in install script, package #632

Closed
JKoelman opened this issue Mar 12, 2014 · 6 comments
Closed

add abort code (J3+) in install script, package #632

JKoelman opened this issue Mar 12, 2014 · 6 comments
Assignees
Labels

Comments

@JKoelman
Copy link
Contributor

@JKoelman JKoelman commented Mar 12, 2014

the thing is that the current code is not intended for Joomla 3 so it would be good to break of an install in Joomla 3 till we fully address it.

@JKoelman JKoelman added this to the JEM 1.9.6 beta milestone Mar 12, 2014
@JKoelman JKoelman added the change label Mar 12, 2014
@Hoffi1
Copy link
Contributor

@Hoffi1 Hoffi1 commented Mar 12, 2014

There is a check to "2.5" in script's preflight() function. Doesn't this work?
(maybe we should check $type to allow "uninstall" on each Joomla version?)

@JKoelman
Copy link
Contributor Author

@JKoelman JKoelman commented Mar 12, 2014

hmm, yes it works but was confused. was thinking that there would be aseperate install-script for the package but will close this one.

@JKoelman JKoelman closed this Mar 12, 2014
@Hoffi1
Copy link
Contributor

@Hoffi1 Hoffi1 commented Mar 12, 2014

Ah, now I understand. You mean the complete package. The script is for component only so maybe modules and plugins would be installed.
Mostly I install parts separately because on package I don't see messages from a part - maybe another todo...

So I think now we should keep it in mind - maybe for later.

@Hoffi1
Copy link
Contributor

@Hoffi1 Hoffi1 commented Mar 20, 2014

A package install script is possible, so we should add one.
I would also use this to automatically activate essential plugin(s).
So I can add the script incl. version check.
(We must ensure always both scripts require same versions. But I would not remove version check from component's script because one could install component only, without package.)

@Hoffi1 Hoffi1 reopened this Mar 20, 2014
@Hoffi1 Hoffi1 self-assigned this Mar 20, 2014
Hoffi1 added a commit to Hoffi1/JEM-Project that referenced this issue Mar 21, 2014
 if first event is deleted (issue jemproject#627),
add version check to package (issue jemproject#632)
Hoffi1 added a commit to Hoffi1/JEM-Project that referenced this issue Mar 22, 2014
@Hoffi1
Copy link
Contributor

@Hoffi1 Hoffi1 commented Mar 22, 2014

Package now contains an install script which

  • checks versions of Joomla, PHP, and MySQL
  • checks if Magic Quotes are disabled
  • checks for required PHP extensions
    as well as after installation
  • clears cache (so Extension Manager should show new version information)
  • activates (new) important jem content plugin
@Hoffi1
Copy link
Contributor

@Hoffi1 Hoffi1 commented Apr 3, 2014

Now available on master branch.

@Hoffi1 Hoffi1 closed this Apr 3, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants