Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

recurrence: no category set on auto-created events #644

Closed
Hoffi1 opened this issue Apr 5, 2014 · 5 comments
Closed

recurrence: no category set on auto-created events #644

Hoffi1 opened this issue Apr 5, 2014 · 5 comments
Assignees
Labels
bug

Comments

@Hoffi1
Copy link
Contributor

@Hoffi1 Hoffi1 commented Apr 5, 2014

Played with different user rights and found curious result:
A normal user (Registered) with add/edit/publish events right via JEM group created recurring event on frontend. Created (first) event was fine but all other events have no category set.

@jojo12: Could you please try to reproduce this with 1.9.6 pre-release?
I think this should be fixed, if possible before 1.9.6 release. (I will do my best)

@Hoffi1 Hoffi1 added this to the JEM 1.9.6 beta milestone Apr 5, 2014
@Hoffi1 Hoffi1 added the bug label Apr 5, 2014
@Hoffi1 Hoffi1 self-assigned this Apr 5, 2014
@Hoffi1
Copy link
Contributor Author

@Hoffi1 Hoffi1 commented Apr 5, 2014

I think I found the cause:
In JemHelper::cleanup() recurring events are generated. When such an event is successfully stored cats_event_relations must be updated. But this query is limited to users with "core.manage" authorization - This is wrong. If event could be stored relations must be stored too, independant of user rights.

@Hoffi1
Copy link
Contributor Author

@Hoffi1 Hoffi1 commented Apr 5, 2014

I think the intention was to print error message to managers only. So it should be fixed now.

@jojo12
Copy link
Contributor

@jojo12 jojo12 commented Apr 6, 2014

I tested after changing (tested before always as superuser). All events in recurrence set have category.

@JKoelman
Copy link
Contributor

@JKoelman JKoelman commented Apr 6, 2014

@Hoffi1 it indeed had to do with showing the error-message but you're right that the code had to change.

@Hoffi1
Copy link
Contributor Author

@Hoffi1 Hoffi1 commented Apr 6, 2014

Available on master so close it now.

@Hoffi1 Hoffi1 closed this Apr 6, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants