New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

frontend choose venue or contact: strange #655

Closed
jojo12 opened this Issue Apr 10, 2014 · 13 comments

Comments

Projects
None yet
4 participants
@jojo12
Contributor

jojo12 commented Apr 10, 2014

when I choose a venue in frontend create/edit event it opens a window with venues
the number of venues for a site is 10 but it shows me about 20 venues. Down it shows more 3 more pages but they don't have content.
When I search a venue, I get bad gateway.

For me this is not bad, but should not be.

@jojo12 jojo12 added the bug label Apr 10, 2014

@JKoelman

This comment has been minimized.

Contributor

JKoelman commented Apr 11, 2014

am not able to recreate the problem so not sure how to solve it.

@JKoelman

This comment has been minimized.

Contributor

JKoelman commented Apr 13, 2014

tried again and am indeed noticing a problem.
-> after adjusting the nr of results the problem went away

default display is 10 but is does not take that into account.

naamloos

@jojo12

This comment has been minimized.

Contributor

jojo12 commented Apr 13, 2014

happy to hear that. So my problem is not so strange, I feared!

@Hoffi1

This comment has been minimized.

Contributor

Hoffi1 commented Apr 13, 2014

Yes, the limit is ignored when box is opened (first time).
If you select another limit this is respected, also if you close the box and open again.

Will take a look into code...

@Hoffi1 Hoffi1 self-assigned this Apr 13, 2014

@Hoffi1 Hoffi1 changed the title from frontend choose venue: strange to frontend choose venue or contact: strange Apr 13, 2014

@Hoffi1

This comment has been minimized.

Contributor

Hoffi1 commented Apr 13, 2014

Same is true for contacts.
There always all contacts are listed. But after changing limit links on navigators are wrong so you get error 500.

Will take a second look too...

Hoffi1 added a commit to Hoffi1/JEM-Project that referenced this issue Apr 15, 2014

fix editevent select venue / contact (issue jemproject#655)
- respect entry limit
- correct url on navigation buttons
not fixed yet: on navigation sorting gets lost
@jojo12

This comment has been minimized.

Contributor

jojo12 commented Apr 16, 2014

Please look question in #667!

Hoffi1 added a commit to Hoffi1/JEM-Project that referenced this issue Apr 16, 2014

more fix editevent select venue / contact (issues jemproject#655, jem…
…project#667)

- hopefully all working on these two popups
- show "No ... found." when table empty
- removed email, address, phone from contacts list (jemproject#667)
- removed "Powered by" from popups, added to all other views (e.g. calendars, edit views)
@Hoffi1

This comment has been minimized.

Contributor

Hoffi1 commented Apr 16, 2014

Should fully work now (on my fork yet).

@jojo12

This comment has been minimized.

Contributor

jojo12 commented Apr 17, 2014

yes

@jojo12 jojo12 removed the bug label Apr 17, 2014

JKoelman added a commit that referenced this issue Apr 17, 2014

Merge pull request #668 from Hoffi1/develop
fix frontend editevent popups, privacy (issues #655, #667)
@JKoelman

This comment has been minimized.

Contributor

JKoelman commented Apr 17, 2014

it seems there is one more issue with this one.
when pressing "search" the selectedfilter changes to the default value
-> did notice it within the venue-view not sure how it's within contact

@Hoffi1

This comment has been minimized.

Contributor

Hoffi1 commented Apr 17, 2014

Ah, you're right. Contacts is ok because there it is consequently named "filter". I tried to make both things as equal as possible but seems I was not good enough.

Have a solution locally which I will provide soon.
Because we allow searching for "1" we should also allow searching for "0" - fixed this too.
(Why: In PHP false, 0, "0", and "" (empty string) are the same. But we need "0" as valid, non-empty string.)

Hoffi1 added a commit to Hoffi1/JEM-Project that referenced this issue Apr 17, 2014

issue jemproject#655 related: keep filter type on choosevenue,
handle searching for "0" same as for "1"

JKoelman added a commit that referenced this issue Apr 17, 2014

Merge pull request #670 from Hoffi1/develop
issue #655 related: keep filter type on choosevenue, handle searching for "0" same as for "1"
@JKoelman

This comment has been minimized.

Contributor

JKoelman commented Apr 17, 2014

think this issue is now been resolved 👍 , but have to do a reinstall to check out the latest changes.

@JKoelman

This comment has been minimized.

Contributor

JKoelman commented Apr 18, 2014

alright not seeing a problem so looks this one can be closed

@JKoelman

This comment has been minimized.

Contributor

JKoelman commented Apr 20, 2014

will close this one for now as it looks ok.

@JKoelman JKoelman closed this Apr 20, 2014

@diesl diesl added the bug label Apr 21, 2014

@diesl diesl added this to the JEM 1.9.7 beta milestone Apr 21, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment