Add an Azure Function for publishing incremental builds to Artifactory

[rtyler]

Per my discussion with @jglick around JEP-305, rather than adding credentials for publishing into Artifactory, this approach allows credentials to stay off of ci.jenkins.io.

This also enforces commit verification and validation against jenkins-infra/repository-permissions-updater metadata before uploading into Artifactory.

It is also largely based on @jglick's orototype work here

[rtyler]

This requires the following changes to be built and released to ci.jenkins.io:

• jenkinsci/github-branch-source-plugin#181
• jenkinsci/scm-api-plugin#53
• jenkinsci/branch-api-plugin#126

Also:

• jenkins-infra/repository-permissions-updater#672

[slide]

This looks really cool.

[jglick]

preferably also repo:status (best to be explicit about what ought to be granted)

[jglick]

Not sure what match means here. Is there a startsWith function? And the prefix URL should end with a / I think.

[rtyler]

There is, that's a good point. Will change

[jglick]

from https://repo.jenkins-ci.org/webapp/#/profile I suppose

[rtyler]

Correct

[jglick]

conform

[jglick]

Trailing slash? (see below)

[jglick]

What is commit here? Seems to be an undefined variable?

[jglick]

No, first you need to check whether the archive is empty.

[jglick]

No, first you need to check whether some representative element of the archive has already been deployed, and if so, skip redeployment.

[jglick]

Nope, you will get a 403 from Artifactory this way because it things you are trying to replace the entire repository.

You need to append archive.zip to the URL.

Been there, done that.

[rtyler]

Hah! That's fun, good to know 😃

[jglick]

Misleading—it may in fact have failed.

[jglick]

This does not work:

Unable to find project root. Expecting to find one of host.json, local.settings.json in project root.

From Azure documentation, I gather that files of these names are supposed to be present here. But they are not.

Just adding host.json

{}

lets the container start, but then it throws all kinds of errors.

[rtyler]

Ah bollocks, I have these files defined locally. Will check them in

[jglick]

Tried with your additions. Still get all kinds of errors at startup:

…
Starting Host (HostId=…, InstanceId=…, …)
Unable to configure java worker. Could not find JAVA_HOME app setting.

Could not configure language worker Java.
…
Host initialized (469ms)
Couldn't require bundle, falling back to Worker.js. Error: Cannot find module '/usr/local/lib/node_modules/azure-functions-core-tools/bin/workers/node/grpc/src/node/extension_binary/node-v59-linux-x64/grpc_node.node'
internal/modules/cjs/loader.js:550
    throw err;
    ^
Error: Cannot find module './Worker.js'
    at Function.Module._resolveFilename (internal/modules/cjs/loader.js:548:15)
    at Function.Module._load (internal/modules/cjs/loader.js:475:25)
    at Module.require (internal/modules/cjs/loader.js:598:17)
    at require (internal/modules/cjs/helpers.js:11:18)
    at Object.<anonymous> (/usr/local/lib/node_modules/azure-functions-core-tools/bin/workers/node/dist/src/nodejsWorker.js:8:14)
    at Module._compile (internal/modules/cjs/loader.js:654:30)
    at Object.Module._extensions..js (internal/modules/cjs/loader.js:665:10)
    at Module.load (internal/modules/cjs/loader.js:566:32)
    at tryModuleLoad (internal/modules/cjs/loader.js:506:12)
    at Function.Module._load (internal/modules/cjs/loader.js:498:3)
Host started (509ms)
Job host started
Worker encountered an error.
Worker process with pid 43 exited with code 1.
…
Couldn't require bundle, falling back to Worker.js. Error: Cannot find module '/usr/local/lib/node_modules/azure-functions-core-tools/bin/workers/node/grpc/src/node/extension_binary/node-v59-linux-x64/grpc_node.node'
internal/modules/cjs/loader.js:550
    throw err;
    ^
Error: Cannot find module './Worker.js'
    at Function.Module._resolveFilename (internal/modules/cjs/loader.js:548:15)
    at Function.Module._load (internal/modules/cjs/loader.js:475:25)
    at Module.require (internal/modules/cjs/loader.js:598:17)
    at require (internal/modules/cjs/helpers.js:11:18)
    at Object.<anonymous> (/usr/local/lib/node_modules/azure-functions-core-tools/bin/workers/node/dist/src/nodejsWorker.js:8:14)
    at Module._compile (internal/modules/cjs/loader.js:654:30)
    at Object.Module._extensions..js (internal/modules/cjs/loader.js:665:10)
    at Module.load (internal/modules/cjs/loader.js:566:32)
    at tryModuleLoad (internal/modules/cjs/loader.js:506:12)
    at Function.Module._load (internal/modules/cjs/loader.js:498:3)
Worker encountered an error.
Worker process with pid 52 exited with code 1.
…
Couldn't require bundle, falling back to Worker.js. Error: Cannot find module '/usr/local/lib/node_modules/azure-functions-core-tools/bin/workers/node/grpc/src/node/extension_binary/node-v59-linux-x64/grpc_node.node'
internal/modules/cjs/loader.js:550
    throw err;
    ^
Error: Cannot find module './Worker.js'
    at Function.Module._resolveFilename (internal/modules/cjs/loader.js:548:15)
    at Function.Module._load (internal/modules/cjs/loader.js:475:25)
    at Module.require (internal/modules/cjs/loader.js:598:17)
    at require (internal/modules/cjs/helpers.js:11:18)
    at Object.<anonymous> (/usr/local/lib/node_modules/azure-functions-core-tools/bin/workers/node/dist/src/nodejsWorker.js:8:14)
    at Module._compile (internal/modules/cjs/loader.js:654:30)
    at Object.Module._extensions..js (internal/modules/cjs/loader.js:665:10)
    at Module.load (internal/modules/cjs/loader.js:566:32)
    at tryModuleLoad (internal/modules/cjs/loader.js:506:12)
    at Function.Module._load (internal/modules/cjs/loader.js:498:3)
Worker encountered an error.
Worker process with pid 59 exited with code 1.
Listening on http://localhost:7071/
…

And every curl command gives a 500 error, with the container log saying:

Executing 'Functions.incrementals-publisher' (Reason='This function was programmatically called via the host APIs.', Id=…)
System.Private.CoreLib: Exception while executing function: Functions.incrementals-publisher. System.Private.CoreLib: One or more errors occurred. (Worker process with pid 43 exited with code 1) (Worker process with pid 52 exited with code 1) (Worker process with pid 59 exited with code 1). Worker process with pid 43 exited with code 1.
Executed 'Functions.incrementals-publisher' (Failed, Id=…)
System.Private.CoreLib: Exception while executing function: Functions.incrementals-publisher. System.Private.CoreLib: One or more errors occurred. (Worker process with pid 43 exited with code 1) (Worker process with pid 52 exited with code 1) (Worker process with pid 59 exited with code 1). Worker process with pid 43 exited with code 1.

[rtyler]

Ah, I neglected to re-push the rtyler/azure-functionis container of which the latest tag is using Node 9. Turns out the Azure Functions runtime requires Node 8.

I'm tethered right now, so I'll have to push when I get back home. Or you could build this your own

[jglick]

Resolved with manual rebuild, FTR.

[jglick]

Still a typo.

Gee this dynamic language thing is great! What was I so worried about?

[olblak]

why do you specify the network host?

[rtyler]

This is because the Azure Functions loader doesn't know (last I checked) won't bind to 0.0.0.0 and instead only binds to localhost

[rtyler]

This all looks good to me, I'm going to merge this and then make sure the appropriate credentials are configured in the "App Service" resource in Azure