Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[JENKINS-49861] Disable executors on master by default #15

Closed
wants to merge 2 commits into from

Conversation

@batmat
Copy link
Collaborator

batmat commented Mar 8, 2018

Refactored/cleaned up the test script. Next step I think is to set up BATS.

https://issues.jenkins-ci.org/browse/JENKINS-49861

@batmat batmat requested a review from rtyler Mar 8, 2018
@jenkinsadmin

This comment has been minimized.

Copy link

jenkinsadmin commented Mar 8, 2018

Build failed; the context from the latest run is:

Expand to view
 ---> 16d5d891a76b
Step 24/29 : COPY scripts/shim-startup-wrapper.sh /usr/local/bin
 ---> Using cache
 ---> 11dc4706ef2d
Step 25/29 : RUN mkdir -p /evergreen
 ---> Using cache
 ---> c31ea63c363d
Step 26/29 : COPY client /evergreen/client
 ---> Using cache
 ---> 930df8626339
Step 27/29 : COPY essentials.yaml /evergreen
 ---> Using cache
 ---> 49a1e9aae79e
Step 28/29 : COPY supervisord.conf /etc/supervisor/conf.d/supervisord.conf
 ---> Using cache
 ---> 987f5bf2e5fb
Step 29/29 : CMD /usr/bin/supervisord -c /etc/supervisor/conf.d/supervisord.conf
 ---> Using cache
 ---> 7371d7fdd11d
Successfully built 7371d7fdd11d
Successfully tagged jenkins/evergreen:latest
./scripts/test-container.sh
Start container under test (port=29100) and wait a bit for its startup:
7930b056f073cfb02fcf6f053afd7b0ab33e68bd5b3c913c7eee0f4d81936773
Waiting for Jenkins startup a bit more...
Waiting for Jenkins startup a bit more...
INFO: Jenkins is fully up and running
Started, running tests.
#################
# Running tests #
#################
Connect to Jenkins and check content... OK!
Check master has no executor... the input device is not a TTY

Cleaning up... G'day!
Makefile:19: recipe for target 'container-check' failed
make: *** [container-check] Error 1
[Pipeline] }
[Pipeline] // stage
[Pipeline] }
[Pipeline] // withEnv
[Pipeline] }
[Pipeline] // node
[Pipeline] End of Pipeline

GitHub has been notified of this commit’s build result

ERROR: script returned exit code 2
Finished: FAILURE

Powered by the Comment Logger

@jenkinsadmin

This comment has been minimized.

Copy link

jenkinsadmin commented Mar 8, 2018

Build failed; the context from the latest run is:

Expand to view
Step 24/29 : COPY scripts/shim-startup-wrapper.sh /usr/local/bin
 ---> Using cache
 ---> 1d1c5c65a901
Step 25/29 : RUN mkdir -p /evergreen
 ---> Using cache
 ---> f60b19b3430b
Step 26/29 : COPY client /evergreen/client
 ---> Using cache
 ---> 1c81f98fcb66
Step 27/29 : COPY essentials.yaml /evergreen
 ---> Using cache
 ---> 03b7170b9521
Step 28/29 : COPY supervisord.conf /etc/supervisor/conf.d/supervisord.conf
 ---> Using cache
 ---> 195ec4eeb9fe
Step 29/29 : CMD /usr/bin/supervisord -c /etc/supervisor/conf.d/supervisord.conf
 ---> Using cache
 ---> 68e42fd1f6d1
Successfully built 68e42fd1f6d1
Successfully tagged jenkins/evergreen:latest
./scripts/test-container.sh
Start container under test (port=31409) and wait a bit for its startup:
4cb5fcecad8373e5e7c19a0b1f208e88438bc72af4358500e86c3474275b3fa1
Waiting for Jenkins startup a bit more...
Waiting for Jenkins startup a bit more...
Waiting for Jenkins startup a bit more...
INFO: Jenkins is fully up and running
Started, running tests.
#################
# Running tests #
#################
Connect to Jenkins and check content... OK!
Check master has no executor... the input device is not a TTY

Cleaning up... G'day!
Makefile:19: recipe for target 'container-check' failed
make: *** [container-check] Error 1
[Pipeline] }
[Pipeline] // stage
[Pipeline] }
[Pipeline] // withEnv
[Pipeline] }
[Pipeline] // node
[Pipeline] End of Pipeline

GitHub has been notified of this commit’s build result

ERROR: script returned exit code 2
Finished: FAILURE

Powered by the Comment Logger

batmat added 2 commits Mar 8, 2018
The test should fail to show it's actually testing something.
Content to make the test pass
@batmat batmat force-pushed the batmat:JENKINS-49861 branch from 6aae791 to 9382522 Mar 8, 2018
@jenkinsadmin

This comment has been minimized.

Copy link

jenkinsadmin commented Mar 8, 2018

Build failed; the context from the latest run is:

Expand to view
 ---> fc554aae3e3c
Step 24/29 : COPY scripts/shim-startup-wrapper.sh /usr/local/bin
 ---> Using cache
 ---> 61c7624a1ee0
Step 25/29 : RUN mkdir -p /evergreen
 ---> Using cache
 ---> 0b1c706d156d
Step 26/29 : COPY client /evergreen/client
 ---> Using cache
 ---> 8b15ff19e9de
Step 27/29 : COPY essentials.yaml /evergreen
 ---> Using cache
 ---> c8da70baa838
Step 28/29 : COPY supervisord.conf /etc/supervisor/conf.d/supervisord.conf
 ---> Using cache
 ---> 7fd73e4e74c6
Step 29/29 : CMD /usr/bin/supervisord -c /etc/supervisor/conf.d/supervisord.conf
 ---> Using cache
 ---> edf332d95afb
Successfully built edf332d95afb
Successfully tagged jenkins/evergreen:latest
./scripts/test-container.sh
Start container under test (port=25915) and wait a bit for its startup:
6a6d02f7778bbd724a540caef4c2b76a8f4b8081aad25e283e0fc0c0b06d30ce
Waiting for Jenkins startup a bit more...
Waiting for Jenkins startup a bit more...
Waiting for Jenkins startup a bit more...
INFO: Jenkins is fully up and running
Started, running tests.
#################
# Running tests #
#################
Connect to Jenkins and check content... OK!
Check master has no executor... 
Cleaning up... G'day!
Makefile:19: recipe for target 'container-check' failed
make: *** [container-check] Error 1
[Pipeline] }
[Pipeline] // stage
[Pipeline] }
[Pipeline] // withEnv
[Pipeline] }
[Pipeline] // node
[Pipeline] End of Pipeline

GitHub has been notified of this commit’s build result

ERROR: script returned exit code 2
Finished: FAILURE

Powered by the Comment Logger

@rtyler

This comment has been minimized.

Copy link
Member

rtyler commented Mar 10, 2018

@batmat After our conversation on Gitter yesterday, I have added the "work-in-progress" label to these two pull requests. Will you remove it when they're ready for a more thorough review?

@batmat

This comment has been minimized.

Copy link
Collaborator Author

batmat commented Mar 11, 2018

Closing as I'm going to dig into configuration as code plugin, so only the test would stay in that case (and I need to adjust it anyway since I introduce shunit in #18)

@batmat batmat closed this Mar 11, 2018
@batmat batmat deleted the batmat:JENKINS-49861 branch Mar 11, 2018
Copy link

oleg-nenashev left a comment

lgtm

@batmat

This comment has been minimized.

Copy link
Collaborator Author

batmat commented Mar 16, 2018

superseded by #21

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
4 participants
You can’t perform that action at this time.