Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WEBSITE-672] - Refresh the HOSTING automated message to reflect the plugin documentation pages #67

Merged
merged 2 commits into from Nov 11, 2019

Conversation

@PierreBtz
Copy link
Contributor

PierreBtz commented Oct 8, 2019

While following the process to host a new plugin I noticed that the documentation part was not up to date with the latest changes:

  • the anchors of the two links didn't exist anymore
  • the message didn't take into account the new preferred way to publish the doc

This is a proposal to refresh with a more up to date message.

* the anchors of the two links didn't exist anymore
* the message didn't take into account the new preferred way to publish the doc
Copy link
Contributor

daniel-beck left a comment

CC @slide

@oleg-nenashev

This comment has been minimized.

Copy link
Contributor

oleg-nenashev commented Oct 12, 2019

Is it a Hacktoberfest pull request just in case? Just to label it properly on our side. See Hacktoberfest in Jenkins. If you do not participate in it, please consider doing so. Your pull requests are much appreciated 👍

@oleg-nenashev oleg-nenashev self-requested a review Oct 12, 2019
Co-Authored-By: Daniel Beck <1831569+daniel-beck@users.noreply.github.com>
@batmat
batmat approved these changes Oct 13, 2019
Copy link
Contributor

batmat left a comment

LGTM

@slide

This comment has been minimized.

Copy link
Collaborator

slide commented Oct 14, 2019

LGTM 👍

@slide
slide approved these changes Oct 14, 2019
Copy link
Contributor

oleg-nenashev left a comment

I like "follow the documentation on documenting your plugin so that your plugin is correctly documented" phrase, but it is a nice improvement :)

If there is a ticket for it, would be nice to add it to the https://issues.jenkins-ci.org/browse/WEBSITE-637 EPIC

@PierreBtz

This comment has been minimized.

Copy link
Contributor Author

PierreBtz commented Oct 17, 2019

@oleg-nenashev here you go https://issues.jenkins-ci.org/browse/WEBSITE-672 do you need me to rewrite my commit message with this for tracking?

@oleg-nenashev

This comment has been minimized.

Copy link
Contributor

oleg-nenashev commented Oct 17, 2019

No need, thanks! Can be tracked from the PR

@oleg-nenashev oleg-nenashev changed the title Refresh the HOSTING automated message [WEBSITE-672] - Refresh the HOSTING automated message Oct 17, 2019
@slide

This comment has been minimized.

Copy link
Collaborator

slide commented Oct 21, 2019

I don't have access to merge in this repo, can someone else do it?

@oleg-nenashev

This comment has been minimized.

Copy link
Contributor

oleg-nenashev commented Nov 11, 2019

I will get it deployed. Fixing up docs and the release cycle in the process

@oleg-nenashev oleg-nenashev changed the title [WEBSITE-672] - Refresh the HOSTING automated message [WEBSITE-672] - Refresh the HOSTING automated message to reflect the plugin documentation pages Nov 11, 2019
@oleg-nenashev oleg-nenashev merged commit ffe4d93 into jenkins-infra:master Nov 11, 2019
1 check passed
1 check passed
continuous-integration/jenkins/pr-merge This commit looks good
Details
@oleg-nenashev

This comment has been minimized.

Copy link
Contributor

oleg-nenashev commented Nov 12, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
5 participants
You can’t perform that action at this time.