Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[INFRA-1571] Permit API requests when there is an Authorization header #1006

Merged
merged 2 commits into from Apr 25, 2018

Conversation

@jglick
Copy link
Contributor

jglick commented Apr 25, 2018

Amending #814 to behave normally when there is an Authorization header, used by requests with API tokens. (If there is an invalid header, Jenkins will just spit back a 403.)

Needed for jenkins-infra/community-functions#10.

I am not able to test this directly, but I tested this model (using the same Apache 2.4.7 as ci.jenkins.io runs IIUC) and it worked.

@rtyler rtyler self-requested a review Apr 25, 2018
@rtyler
rtyler approved these changes Apr 25, 2018
Copy link
Member

rtyler left a comment

This looks good to me, I'm going to do some more checks on this tomorrow (Wednesday) and then merge/deploy it.

@jenkinsadmin

This comment has been minimized.

Copy link

jenkinsadmin commented Apr 25, 2018

Build failed; the context from the latest run is:

Expand to view
  should contain Sudo::Conf[root]

profile::diagnostics
  should contain Package[htop]
  should contain Package[strace]
  should contain Class[datadog_agent]

Finished in 27.22 seconds (files took 1.61 seconds to load)
74 examples, 0 failures

Randomized with seed 45350

  should contain Class[docker]
  should contain Class[sudo]
  atlassian sudo specifics
    should contain Sudo::Conf[atlassian-admins]

Finished in 27.87 seconds (files took 1.59 seconds to load)
72 examples, 0 failures

Randomized with seed 15297

Tests Failed

536 examples, 1 failure

Took 30 seconds
[Pipeline] }
[Pipeline] // withEnv
[Pipeline] }
$ docker stop --time=1 75265229cdde8990c96b9b13edebfe7595a51813e32fd54e3fa735a3c0d5046c
$ docker rm -f 75265229cdde8990c96b9b13edebfe7595a51813e32fd54e3fa735a3c0d5046c
[Pipeline] // withDockerContainer
[Pipeline] }
[Pipeline] // withEnv
[Pipeline] }
[Pipeline] // node
[Pipeline] }
[Pipeline] // stage
[Pipeline] }
[Pipeline] // timestamps
[Pipeline] }
[Pipeline] // timeout
[Pipeline] End of Pipeline

GitHub has been notified of this commit’s build result

ERROR: script returned exit code 1
Finished: FAILURE

Powered by the Comment Logger

@olblak

This comment has been minimized.

Copy link
Contributor

olblak commented Apr 25, 2018

👍

@rtyler rtyler merged commit e9cf6a8 into jenkins-infra:staging Apr 25, 2018
1 check passed
1 check passed
continuous-integration/jenkins/pr-merge This commit looks good
Details
@jglick jglick deleted the jglick:authenticated-api-INFRA-1571 branch Apr 25, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
4 participants
You can’t perform that action at this time.