Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[JENKINS-53832,JENKINS-53924] - Reference the GNU C compat issues on RHEL5/ CentOS 5 in the changelog #1815

Conversation

5 participants
@@ -1813,6 +1813,11 @@
# issue: 51603 too minor
- version: "2.138.1"
date: 2018-09-12
banner: >

This comment has been minimized.

Copy link
@daniel-beck

daniel-beck Oct 6, 2018

Contributor

No longer running on decade+ old, unsupported OSes does not warrant a banner.

This comment has been minimized.

Copy link
@oleg-nenashev

oleg-nenashev Oct 6, 2018

Author Contributor

@daniel-beck RHEL 5 is on extended support almost till 2021: https://en.wikipedia.org/wiki/Red_Hat_Enterprise_Linux#Version_history_and_timeline

I can confirm that I know some companies using RHEL 5 in 2019 (in addition to the ticket)

This comment has been minimized.

Copy link
@daniel-beck

daniel-beck Oct 6, 2018

Contributor

Great. They are why we're adding it to the upgrade guide. But I doubt this is common enough to warrant a banner.


For comparison, our LTS banners so far:

  • Java 7 required, impacting Maven projects, SSH slaves
  • Jenkins 2
  • Additional unscheduled LTS release fixing a 0 day vulnerability
  • Java 8 required, impacting Maven projects, SSH slaves
  • 2 regressions discovered during LTS testing
  • Newly detached command launcher plugin doesn't actually get installed, breaking other plugins
  • JEP-200

TBF, in hindsight the two regressions in 2.73.1 probably shouldn't have made it there either. But everything else is a lot more notable than this.

This comment has been minimized.

Copy link
@krisdevopsbot

krisdevopsbot Dec 27, 2018

Yep, we have centos/rhel5 agents to build certain C++ apps and ran into this

still disagree as per above, but leaving it up to Oleg, I don't have the time to look into this further.

oleg-nenashev added some commits Oct 6, 2018

@oleg-nenashev

This comment has been minimized.

Copy link
Contributor Author

commented Oct 6, 2018

@daniel-beck I believe the banner makes sense in this case unless installation stats prove that it impacts <5% of instances. But I removed it anyway, I would prefer to have something in place

@daniel-beck

This comment has been minimized.

Copy link
Contributor

commented Oct 8, 2018

unless installation stats prove that it impacts <5% of instances

We don't have those stats.

It took more than 7 weeks to be discovered though (or 2 weeks after .1 LTS release), which indicates only a small part of the overall user base, or relatively low impact when encountered. Based on usage stats, it looks like 50+k installs of 2.136+ happened, before this was reported.

None of this screams "banner needed".

I'll merge the current PR so we have some docs, and we can look into a banner independently.

@daniel-beck daniel-beck merged commit 3b9b60c into jenkins-infra:master Oct 8, 2018

1 check passed

continuous-integration/jenkins/pr-merge This commit looks good
Details
@bharsh

This comment has been minimized.

Copy link

commented Dec 11, 2018

Late comment: would have been nice to have a banner or prevent the update entirely if prereq's not there in the OS. 2nd time I've done this recovery bit for this same reason too... Maybe this time I'll remember not to touch that Jenkins red box pleading with me to upgrade. I've got it running again but none of our users can log in, it's like the user DB has blown itself away somehow. Ugh.

@daniel-beck

This comment has been minimized.

Copy link
Contributor

commented Dec 14, 2018

@bharsh We discovered this after we published the release, so that's not really possible unless you're comfortable with us injecting code into your instance as part of the update check.

I encourage you to participate in LTS RC testing. Threads for it are regularly posted to the jenkinsci-dev list, e.g. https://groups.google.com/d/msg/jenkinsci-dev/Lsludh80lVM/vwG5rtCSBQAJ

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.