Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WEBSITE-531] Add new CLI commands for enabling and disabling plugins #1885

Merged
merged 5 commits into from Nov 14, 2018

Conversation

@fcojfernandez
Copy link
Contributor

commented Nov 13, 2018

See WEBSITE-531

New CLI commands for enabling and disabling plugins have been included in Jenkins:

  • enable-plugin command was included in jenkins-2.136
  • disable-plugin command was included in jenkins-2.151

Let's update the managing plugins contents referring those commands.

cli-commands

@reviewbybees
@jvz @MRamonLeon as developers

content/doc/book/managing/plugins.adoc Outdated Show resolved Hide resolved
content/doc/book/managing/plugins.adoc Outdated Show resolved Hide resolved
content/doc/book/managing/plugins.adoc Show resolved Hide resolved
@MRamonLeon
Copy link
Contributor

left a comment

Language changes left to our native mates 😉

content/doc/book/managing/plugins.adoc Outdated Show resolved Hide resolved
content/doc/book/managing/plugins.adoc Outdated Show resolved Hide resolved
content/doc/book/managing/plugins.adoc Outdated Show resolved Hide resolved
content/doc/book/managing/plugins.adoc Outdated Show resolved Hide resolved
content/doc/book/managing/plugins.adoc Outdated Show resolved Hide resolved
content/doc/book/managing/plugins.adoc Outdated Show resolved Hide resolved
content/doc/book/managing/plugins.adoc Outdated Show resolved Hide resolved
content/doc/book/managing/plugins.adoc Outdated Show resolved Hide resolved
content/doc/book/managing/plugins.adoc Outdated Show resolved Hide resolved
@batmat
batmat approved these changes Nov 13, 2018
Copy link
Contributor

left a comment

A few comments, but nothing blatantly wrong from my PoV. 👍

content/doc/book/managing/plugins.adoc Outdated Show resolved Hide resolved
content/doc/book/managing/plugins.adoc Outdated Show resolved Hide resolved
@MRamonLeon
Copy link
Contributor

left a comment

LGTM

@jvz
jvz approved these changes Nov 13, 2018
Copy link
Contributor

left a comment

Reads well enough to me! Only found a missing comma.

content/doc/book/managing/plugins.adoc Outdated Show resolved Hide resolved
@jeffret-b
Copy link

left a comment

This is looking good. I've got a few minor suggestions for improvement.

content/doc/book/managing/plugins.adoc Outdated Show resolved Hide resolved
content/doc/book/managing/plugins.adoc Outdated Show resolved Hide resolved
Disable one or more installed plugins.
Disable the plugins with the given short names. You can define how to proceed with the
dependant plugins and if a restart after should be done. You can also set the quiet mode

This comment has been minimized.

Copy link
@jeffret-b

jeffret-b Nov 13, 2018

"dependant" should go to "dependent" in all instances in this document.

(Discussion here on how the British use the two different spellings and Americans only the "dependent" form: https://www.k12reader.com/term/dependent-vs-dependant/ )

This comment has been minimized.

Copy link
@bitwiseman

bitwiseman Nov 14, 2018

Contributor

This is a copy of the CLI right? So, again out of scope for this change.

In the same way than enabling and disabling plugins from the UI need a restart
to complete the process, the changes made with the CLI commands will take effect
once Jenkins is restarted. The `-restart` option forces a safe restart of the
instance once the command has successfully finished, so the changes will be

This comment has been minimized.

Copy link
@jeffret-b

jeffret-b Nov 13, 2018

I would drop the comma in "finished, so". It isn't needed and disrupts the flow.

content/doc/book/managing/plugins.adoc Show resolved Hide resolved
content/doc/book/managing/plugins.adoc Outdated Show resolved Hide resolved
bitwiseman added 2 commits Nov 14, 2018

@bitwiseman bitwiseman force-pushed the fcojfernandez:WEBSITE-531 branch from b799c4e to a2a7ca9 Nov 14, 2018

@bitwiseman

This comment has been minimized.

Copy link
Contributor

commented Nov 14, 2018

@fcojfernandez I made some changes for clarity. I committed directly for expediency. If you disagree with them please revert them.

@fcojfernandez

This comment has been minimized.

Copy link
Contributor Author

commented Nov 14, 2018

@bitwiseman thanks for your collaboration! You're changes and direct commits are entirely fine for me

@bitwiseman bitwiseman merged commit 7f91fd1 into jenkins-infra:master Nov 14, 2018

1 check passed

continuous-integration/jenkins/pr-merge This commit looks good
Details

@fcojfernandez fcojfernandez deleted the fcojfernandez:WEBSITE-531 branch Nov 15, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
8 participants
You can’t perform that action at this time.