Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[JENKINS-29922] Documentation update #324

Merged
merged 1 commit into from Jul 28, 2016

Conversation

4 participants
@jglick
Copy link
Contributor

jglick commented Jul 28, 2016

Downstream of jenkinsci/workflow-cps-plugin#35. Similar to jenkinsci/pipeline-plugin#401; someone seems to have copied & pasted a bunch of documentation, so now we have two copies to maintain.

@reviewbybees esp. @kohsuke, @abayer

step([$class: 'ArtifactArchiver', artifacts: '**/target/*.jar', fingerprint: true])
step([$class: 'JUnitResultArchiver', testResults: '**/target/surefire-reports/TEST-*.xml'])
archiveArtifacts artifacts: '**/target/*.jar', fingerprint: true
junit '**/target/surefire-reports/TEST-*.xml'

This comment has been minimized.

Copy link
@rtyler

This comment has been minimized.

Copy link
@jglick

jglick Jul 28, 2016

Author Contributor

FYI, this is the result of JUnitResultArchiver

  • being a SimpleBuildStep
  • having a @Symbol on its Descriptor
  • having a one-argument @DataBoundConstructor

This comment has been minimized.

Copy link
@jglick

jglick Jul 28, 2016

Author Contributor

Which reminds me, I need to update the dev guide accordingly…

def mvnHome = tool 'M3'
sh "${mvnHome}/bin/mvn -B -Dmaven.test.failure.ignore verify"
step([$class: 'ArtifactArchiver', artifacts: '**/target/*.jar', fingerprint: true])
step([$class: 'JUnitResultArchiver', testResults: '**/target/surefire-reports/TEST-*.xml'])
archiveArtifacts artifacts: '**/target/*.jar', fingerprint: true

This comment has been minimized.

Copy link
@rtyler

rtyler Jul 28, 2016

Member

For my own edification, does this mean that archive is no longer supported or does it just not have the same options (fingerprint: true) as archiveArtifact?

This comment has been minimized.

Copy link
@jglick

jglick Jul 28, 2016

Author Contributor

The latter.

@reviewbybees

This comment has been minimized.

Copy link

reviewbybees commented Jul 28, 2016

This pull request originates from a CloudBees employee. At CloudBees, we require that all pull requests be reviewed by other CloudBees employees before we seek to have the change accepted. If you want to learn more about our process please see this explanation.

@abayer

This comment has been minimized.

Copy link
Contributor

abayer commented Jul 28, 2016

🐝, though I'm not sure if we should merge this before the relevant changes in the various plugins have been released.

@rtyler

This comment has been minimized.

Copy link
Member

rtyler commented Jul 28, 2016

@jglick @abayer oh, the plugin changes for this haven't been released yet? I kind of assumed they would have been for this PR to be created.

If that's the case, please let me know when they're out there and I will merge.

@rtyler rtyler self-assigned this Jul 28, 2016

@jglick

This comment has been minimized.

Copy link
Contributor Author

jglick commented Jul 28, 2016

Released, should appear on UC soon.

@jglick

This comment has been minimized.

Copy link
Contributor Author

jglick commented Jul 28, 2016

On the UC.

@rtyler rtyler merged commit fbffdfe into jenkins-infra:master Jul 28, 2016

@jglick jglick deleted the jglick:JENKINS-29922-docs branch Jul 28, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.