Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changelog and upgrade guide for 2.46.1 #764

Merged
merged 7 commits into from Mar 29, 2017

Conversation

@olivergondza
Copy link
Member

olivergondza commented Mar 21, 2017

message: Exceptions during Jenkins cleanup step should not block restart.
issue: 42164
- type: bug
message: Cryptic error message when loading JnlpSlaveAgentProtocol4. <<< AUTOGENERATED (https://issues.jenkins-ci.org/browse/JENKINS-41987)

This comment has been minimized.

Copy link
@daniel-beck

daniel-beck Mar 22, 2017

Contributor

"AUTOGENERATED"?

This comment has been minimized.

Copy link
@olivergondza

olivergondza Mar 23, 2017

Author Member

That is a reminder to review the generated entry and delete the note. It clearly does not work ...

@@ -140,6 +140,64 @@
message: Do not fail to write a log file just because something deleted the parent directory.
issue: 16634
pull: 2738
- version: "2.46.1"
date: 2017-03-19

This comment has been minimized.

Copy link
@daniel-beck

daniel-beck Mar 22, 2017

Contributor

Wrong date.

@daniel-beck
Copy link
Contributor

daniel-beck commented Mar 22, 2017

@olivergondza To clarify, you're planning to do neither the upgrade guide contents nor the notable changes since 2.32.x?

@olivergondza
Copy link
Member Author

olivergondza commented Mar 24, 2017

Sorry, busy week. I will have a look at the notable changes at Monday.

lts_baseline: "2.46"
lts_changes:
- type: rfe
message: Update the SSHD module from 1.7 to 1.8. The change disables obsolete Ciphers: AES128CBC, TripleDESCBC, and BlowfishCBC.

This comment has been minimized.

Copy link
@oleg-nenashev

oleg-nenashev Mar 27, 2017

Contributor

According to POM XML, the version is 1.9. This entry comes from the 2.34, and it conflicts with the entrues for 2.37:

  • Update SSHD Core from 0.8.0 to 0.14.0. (pull 2662)
  • SSHD Module: Handshake was failing (wrong shared secret) 1 out of 256 times due to SSHD-330. (issue 40362)
message: Exceptions during Jenkins cleanup step should not block restart.
issue: 42164
- type: bug
message: Cryptic error message when loading JnlpSlaveAgentProtocol4.

This comment has been minimized.

Copy link
@oleg-nenashev

oleg-nenashev Mar 27, 2017

Contributor

From what I see there is no such entry in the Weekly changelog. It should have been noted for 2.47. IMHO the entry should be also more human-readable

This comment has been minimized.

Copy link
@olivergondza

olivergondza Mar 28, 2017

Author Member

That happens for LTS when the change does not seem to be noteworthy when merged but get backported eventually.

This comment has been minimized.

Copy link
@oleg-nenashev

oleg-nenashev Mar 28, 2017

Contributor

Will add it to the Weekly changelog then. Better safe then sorry

message: Properties were not passed to Maven command by Maven build step when the Inject Build Variables flag was not set.
issue: 39268
- type: rfe
message: Enable the JNLP4 agent protocol by default.

This comment has been minimized.

lts_baseline: "2.46"
lts_changes:
- type: rfe
message: Update the SSHD module from 1.7 to 1.8. The change disables obsolete Ciphers: AES128CBC, TripleDESCBC, and BlowfishCBC.

This comment has been minimized.

Copy link
@rtyler

rtyler Mar 27, 2017

Member

This "message" should be quoted, otherwise it's not valid YAML (due to the colons fwiw)

An error occurred: (/home/jenkins/workspace/Infra_jenkins.io_PR-764-NYRWJGUU4XY76C35W6WKURUQQGJVESLRGXZL7GGWN3MFTWWRZL7Q/content/_data/changelogs/lts.yml): mapping values are not allowed here at line 149 column 92
org/jruby/ext/psych/PsychParser.java:227:in `parse'
references:
- issue: 40886
- url: https://github.com/jenkinsci/remoting/blob/master/docs/protocols.md#jnlp4-connect
title: upgrade notes

This comment has been minimized.

Copy link
@oleg-nenashev

oleg-nenashev Mar 28, 2017

Contributor

It is not a link to upgrade notes. It is just a protocol description

This comment has been minimized.

Copy link
@olivergondza

olivergondza Mar 28, 2017

Author Member

I know, could not think of a better title.

This comment has been minimized.

Copy link
@oleg-nenashev

oleg-nenashev Mar 29, 2017

Contributor

Maybe a link to the upgrade guildelines section then?

message: Exceptions during Jenkins cleanup step should not block restart.
issue: 42164
- type: bug
message: Cryptic error message when loading JnlpSlaveAgentProtocol4.

This comment has been minimized.

Copy link
@oleg-nenashev

oleg-nenashev Mar 28, 2017

Contributor

Will add it to the Weekly changelog then. Better safe then sorry

@daniel-beck daniel-beck self-assigned this Mar 29, 2017
Copy link
Contributor

oleg-nenashev left a comment

LGTM, with some improvement proposals


==== JNLP4 remoting protocol enabled by default

The JNLP4 protocol is now enabled by default for JNLP agent connections. It's more reliable than JNLP3, and also encrypted, making it the best choice for agent connections. Use of this protocol may require upgrades of +slave.jar+ files on agents.

This comment has been minimized.

This comment has been minimized.

Copy link
@oleg-nenashev

oleg-nenashev Mar 29, 2017

Contributor

Unfortunately we have no documentation page for upgrading agents :(


==== Obsolete ciphers removed from SSHD

Jenkins exposes an SSH server that allows use of CLI commands via SSH. In this SSH server, support for the obsolete ciphers AES128CBC, TripleDESCBC, and BlowfishCBC has been removed.

This comment has been minimized.

Copy link
@oleg-nenashev

oleg-nenashev Mar 29, 2017

Contributor

Add: "SSH clients using these versions won't be able to connect to Jenkins. It should not affect modern systems"

---
layout: documentation
title: Jenkins Upgrade Guide
notitle: true

This comment has been minimized.

Copy link
@oleg-nenashev

oleg-nenashev Mar 29, 2017

Contributor

no tags?

This comment has been minimized.

Copy link
@daniel-beck

daniel-beck Mar 29, 2017

Contributor

it's not a blog post

@daniel-beck
Copy link
Contributor

daniel-beck commented Mar 29, 2017

FTR:

screen shot

@daniel-beck
Copy link
Contributor

daniel-beck commented Mar 29, 2017

Merging as-is, minor improvements can always be done separately later.

@daniel-beck daniel-beck merged commit 606eaa1 into jenkins-infra:master Mar 29, 2017
1 check passed
1 check passed
continuous-integration/jenkins/pr-merge This commit looks good
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
You can’t perform that action at this time.