Chore: Allow running tests with OpenJDK 11 and 15: bump Groovy and Junit dependencies #173
Conversation
Signed-off-by: dduportal <damien.duportal@gmail.com>
Signed-off-by: dduportal <damien.duportal@gmail.com>
Signed-off-by: dduportal <damien.duportal@gmail.com>
| </properties> | ||
|
|
||
| <dependencies> | ||
| <dependency> | ||
| <groupId>org.codehaus.groovy</groupId> | ||
| <artifactId>groovy-all</artifactId> | ||
| <version>${groovy.version}</version> | ||
| <!-- Type pom replaces the über "groovy-all.jar", for version 3+ --> | ||
| <type>pom</type> |
There was a problem hiding this comment.
do we still need this groovy dependency? or should we be specifying just the actual groovy jar? seems weird to depend on a pom artifact?
There was a problem hiding this comment.
I have no idea if it is required or not. On 1 side it might be right as this dependency is not mentionned in https://github.com/jenkinsci/JenkinsPipelineUnit#add-to-your-project-as-test-dependency .
On the other, my knowledge is not sufficient enough how to make this work without this 😱
It looks like that the groovy-all (e.g. the Eclipse Groovy Compiler) is not the only solution: https://docs.groovy-lang.org/latest/html/documentation/tools-groovyc.html#section-groovyeclipse . But it is recommended when there is a joint Java-Groovy compilation, which should be the case for shared library if I understand correctly the src/** usage is that right?
=> If this assumption is valid, then https://github.com/groovy/groovy-eclipse/wiki/Groovy-Eclipse-Maven-plugin is to be used, but there is no mention of groovy-all in this doc. So I don't really know 🤷🏾♂️
There was a problem hiding this comment.
| <groupId>junit</groupId> | ||
| <artifactId>junit</artifactId> | ||
| <groupId>org.junit.jupiter</groupId> | ||
| <artifactId>junit-jupiter-api</artifactId> |
This PR allows executing the library's unit tests (
mvn clean test) when you have a recent OpenJDK (11 or 15).It involves bumping the Groovy dependency (and associated compiler sub-dependencies) to 3.x (instead of 2.x), as well as Junit to 5.x.
Please note that the
pom.xmlis still specifying a compile target as1.8as before of course.