[INFRA-1953] Make pipeline-library#runATH step runs with old ATH sources and images #84
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alecharp
approved these changes
Jan 3, 2019
MRamonLeon
commented
Jan 3, 2019
MRamonLeon
commented
Jan 3, 2019
olivergondza
reviewed
Jan 3, 2019
Keep the containerArgs as it was, add some extra information and fail the build if java11 required but set-java.sh not found
MRamonLeon
commented
Jan 4, 2019
There was a problem hiding this comment.
Failure on Java11 without set-env.sh and just a message on Java8. @olivergondza @batmat
|
@olivergondza @raul-arabaolaza Does these changes look good to you? Thank you. |
raul-arabaolaza
approved these changes
Jan 8, 2019
olivergondza
approved these changes
Jan 8, 2019
batmat
approved these changes
Jan 8, 2019
|
@MRamonLeon it seems good, but why did you change it to invoke each command at a time instead of all of them together? Just out of curiosity. |
|
@varyvol No specific reason. Probably I forgot to add the && after the if. Good point. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See Make pipeline-library#runATH step runs with old ATH sources and images
This PR allows you to use the runATH step with old ATH sources and images. With this, your builds will not fail if the pipeline-library is not on sync with the ATH sources and images used.
@batmat @alecharp @raul-arabaolaza @olivergondza