Actually switch to pipeline-metadata-utils 1.1

[abayer]

Replaces #3

[rtyler]

Removing code 🎈 🎉 🍰

[abayer]

...of course, as I work on this, I wonder whether I actually want to have this be a separate library or do the Declarative generation here too. Hrrrrrm.

[kwhetstone]

+1 for abstracting out. There are some general improvements I'd like to make to the ToAsciiDoc method anyway. What would you like to see for declarative?

[abayer]

@kwhetstone Welp, see #12 - I think it probably does make sense to just keep it all in one library for now after all. Sigh. =)

[gilesgas]

Hi @abayer ,
Please correct me if I'm wrong, although I noticed that the steps reference documentation for the "Pipeline: Input Step" plugin (https://jenkins.io/doc/pipeline/steps/pipeline-input-step/) appears to be pulling in (or generating) content from other plugin's / class's documentation. I.e. This page seems to be much longer than what it should be.
Do you think this PR would fix issues like this?
Cheers,
Giles.

[jenkinsadmin]

The context from the Jenkins Pipeline run is:

Branch indexing
Connecting to https://api.github.com using jenkinsadmin/****** (GitHub access token for jenkinsadmin)
Checking out git https://github.com/jenkins-infra/pipeline-steps-doc-generator.git into /var/jenkins_home/jobs/Infra/jobs/pipeline-steps-doc-generator/branches/PR-11/workspace@script to read Jenkinsfile
Fetching changes from the remote Git repository
Fetching without tags
Merging remotes/origin/master commit 7b7f1692ca3fb2138787190bdab6f7ba7c6bcaeb into PR head commit c98f122dfcdbfccb716246ab17d1a86b5b5cb3b0

GitHub has been notified of this commit’s build result

hudson.plugins.git.GitException: Failed to merge AnyObjectId[7b7f1692ca3fb2138787190bdab6f7ba7c6bcaeb]
	at org.jenkinsci.plugins.gitclient.JGitAPIImpl$6.execute(JGitAPIImpl.java:1560)
	at jenkins.plugins.git.MergeWithGitSCMExtension.decorateRevisionToBuild(MergeWithGitSCMExtension.java:122)
	at hudson.plugins.git.GitSCM.determineRevisionToBuild(GitSCM.java:1068)
	at hudson.plugins.git.GitSCM.checkout(GitSCM.java:1161)
	at org.jenkinsci.plugins.workflow.steps.scm.SCMStep.checkout(SCMStep.java:113)
	at org.jenkinsci.plugins.workflow.cps.CpsScmFlowDefinition.create(CpsScmFlowDefinition.java:130)
	at org.jenkinsci.plugins.workflow.multibranch.SCMBinder.create(SCMBinder.java:120)
	at org.jenkinsci.plugins.workflow.job.WorkflowRun.run(WorkflowRun.java:262)
	at hudson.model.ResourceController.execute(ResourceController.java:97)
	at hudson.model.Executor.run(Executor.java:421)
Finished: FAILURE

powered by the Comment Logger

[jenkinsadmin]

The context from the Jenkins Pipeline run is:

Started by timer
Connecting to https://api.github.com using jenkinsadmin/****** (GitHub access token for jenkinsadmin)
Checking out git https://github.com/jenkins-infra/pipeline-steps-doc-generator.git into /var/jenkins_home/jobs/Infra/jobs/pipeline-steps-doc-generator/branches/PR-11/workspace@script to read Jenkinsfile
Fetching changes from the remote Git repository
Fetching without tags
Merging remotes/origin/master commit 7b7f1692ca3fb2138787190bdab6f7ba7c6bcaeb into PR head commit c98f122dfcdbfccb716246ab17d1a86b5b5cb3b0

GitHub has been notified of this commit’s build result

hudson.plugins.git.GitException: Failed to merge AnyObjectId[7b7f1692ca3fb2138787190bdab6f7ba7c6bcaeb]
	at org.jenkinsci.plugins.gitclient.JGitAPIImpl$6.execute(JGitAPIImpl.java:1560)
	at jenkins.plugins.git.MergeWithGitSCMExtension.decorateRevisionToBuild(MergeWithGitSCMExtension.java:122)
	at hudson.plugins.git.GitSCM.determineRevisionToBuild(GitSCM.java:1068)
	at hudson.plugins.git.GitSCM.checkout(GitSCM.java:1161)
	at org.jenkinsci.plugins.workflow.steps.scm.SCMStep.checkout(SCMStep.java:113)
	at org.jenkinsci.plugins.workflow.cps.CpsScmFlowDefinition.create(CpsScmFlowDefinition.java:130)
	at org.jenkinsci.plugins.workflow.multibranch.SCMBinder.create(SCMBinder.java:120)
	at org.jenkinsci.plugins.workflow.job.WorkflowRun.run(WorkflowRun.java:262)
	at hudson.model.ResourceController.execute(ResourceController.java:97)
	at hudson.model.Executor.run(Executor.java:421)
Finished: FAILURE

powered by the Comment Logger

[jenkinsadmin]

The context from the Jenkins Pipeline run is:

Started by timer
Connecting to https://api.github.com using jenkinsadmin/****** (GitHub access token for jenkinsadmin)
Checking out git https://github.com/jenkins-infra/pipeline-steps-doc-generator.git into /var/jenkins_home/jobs/Infra/jobs/pipeline-steps-doc-generator/branches/PR-11/workspace@script to read Jenkinsfile
Fetching changes from the remote Git repository
Fetching without tags
Merging remotes/origin/master commit 7b7f1692ca3fb2138787190bdab6f7ba7c6bcaeb into PR head commit c98f122dfcdbfccb716246ab17d1a86b5b5cb3b0

GitHub has been notified of this commit’s build result

hudson.plugins.git.GitException: Failed to merge AnyObjectId[7b7f1692ca3fb2138787190bdab6f7ba7c6bcaeb]
	at org.jenkinsci.plugins.gitclient.JGitAPIImpl$6.execute(JGitAPIImpl.java:1560)
	at jenkins.plugins.git.MergeWithGitSCMExtension.decorateRevisionToBuild(MergeWithGitSCMExtension.java:122)
	at hudson.plugins.git.GitSCM.determineRevisionToBuild(GitSCM.java:1068)
	at hudson.plugins.git.GitSCM.checkout(GitSCM.java:1161)
	at org.jenkinsci.plugins.workflow.steps.scm.SCMStep.checkout(SCMStep.java:113)
	at org.jenkinsci.plugins.workflow.cps.CpsScmFlowDefinition.create(CpsScmFlowDefinition.java:130)
	at org.jenkinsci.plugins.workflow.multibranch.SCMBinder.create(SCMBinder.java:120)
	at org.jenkinsci.plugins.workflow.job.WorkflowRun.run(WorkflowRun.java:262)
	at hudson.model.ResourceController.execute(ResourceController.java:97)
	at hudson.model.Executor.run(Executor.java:421)
Finished: FAILURE

powered by the Comment Logger

[jglick]

the steps reference documentation for the "Pipeline: Input Step" plugin (https://jenkins.io/doc/pipeline/steps/pipeline-input-step/) appears to be pulling in (or generating) content from other plugin's / class's documentation. I.e. This page seems to be much longer than what it should be.

No, it just accepts a fairly widely implemented extension point (ParameterDefinition) for one of its properties.

[abayer]

Closing this sucker, since there's no real point to it with #12 merged.