Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update artifact-ignores.properties #405

Merged

Conversation

andreashoyerh2m
Copy link
Contributor

@andreashoyerh2m andreashoyerh2m commented Jul 22, 2020

Depublish "sonargraph-plugin". It worked with Sonargraph version 7 which is now discontinued. Sonargraph version 8/9/10 is supported by "sonargraph-integration", which is the successor of "sonargraph-plugin".

@oleg-nenashev
Copy link
Member

@oleg-nenashev oleg-nenashev commented Jul 23, 2020

Maybe it is better to mark the plugin as deprecated and archive it, but no strong opinion

@andreashoyerh2m
Copy link
Contributor Author

@andreashoyerh2m andreashoyerh2m commented Jul 30, 2020

It should have been deprecated two years ago, whilst Sonargraph 7 was still 'working' theoretically, but we missed that. Now this plugin cant be used anymore, and I think depublishing is the right thing to do.

@daniel-beck
Copy link
Contributor

@daniel-beck daniel-beck commented Jul 30, 2020

@andreashoyerh2m Given ~2400 installations, it probably makes sense to also mark it as deprecated via resource file: https://github.com/jenkins-infra/update-center2#deprecations

Doing that will show a message to admins who have it installed.

@daniel-beck daniel-beck added the metadata label Jul 30, 2020
yJunS
yJunS approved these changes Jul 30, 2020
@andreashoyerh2m
Copy link
Contributor Author

@andreashoyerh2m andreashoyerh2m commented Jul 30, 2020

Marked it as deprecated

@daniel-beck
Copy link
Contributor

@daniel-beck daniel-beck commented Jul 31, 2020

@andreashoyerh2m Looks like I wasn't clear: for a suspended plugin, the second option needs to be used. There's nowhere to attach labels to in the metadata.

Copy link
Member

@oleg-nenashev oleg-nenashev left a comment

Thanks!

@oleg-nenashev oleg-nenashev merged commit ff238e2 into jenkins-infra:master Aug 10, 2020
2 checks passed
@daniel-beck
Copy link
Contributor

@daniel-beck daniel-beck commented Aug 10, 2020

@oleg-nenashev Per my comment, this wasn't done. The label will never be applied.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
metadata
Projects
None yet
5 participants