Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move to apps org and new repo. Updated all references. #48

Merged
merged 2 commits into from Jan 25, 2019

Conversation

deanesmith
Copy link
Contributor

No description provided.

Copy link
Contributor

@jglick jglick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow there is a lot of boilerplate to update here. I wonder if buildpacks can be improved to deduplicate somewhat, and even infer GITHUB_ORG and APP_NAME from the checkout location.

Jenkinsfile Show resolved Hide resolved
charts/jx-app-jacoco/values.yaml Outdated Show resolved Hide resolved
charts/preview/Makefile Show resolved Hide resolved
@jglick
Copy link
Contributor

jglick commented Jan 25, 2019

BTW using Go 1.11.5 I cannot build without

diff --git a/go.sum b/go.sum
index 5defe2b..052d7e5 100644
--- a/go.sum
+++ b/go.sum
@@ -230,7 +230,7 @@ k8s.io/apiextensions-apiserver v0.0.0-20180621085152-bbc52469f98b h1:q6seqITE2eU
 k8s.io/apiextensions-apiserver v0.0.0-20180621085152-bbc52469f98b/go.mod h1:IxkesAMoaCRoLrPJdZNZUQp9NfZnzqaVzLhb2VEQzXE=
 k8s.io/apimachinery v0.0.0-20180621070125-103fd098999d h1:MZjlsu9igBoVPZkXpIGoxI6EonqNsXXZU7hhvfQLkd4=
 k8s.io/apimachinery v0.0.0-20180621070125-103fd098999d/go.mod h1:ccL7Eh7zubPUSh9A3USN90/OzHNSVN6zxzde07TDCL0=
-k8s.io/client-go v8.0.0+incompatible h1:7Zl+OVXn0bobcsi4NEZGdoQDTE9ij1zPMfM21+yqQsM=
+k8s.io/client-go v8.0.0+incompatible h1:tTI4hRmb1DRMl4fG6Vclfdi6nTM82oIrTT7HfitmxC4=
 k8s.io/client-go v8.0.0+incompatible/go.mod h1:7vJpHMYJwNQCWgzmNV+VYUl1zCObLyodBc8nIyt8L5s=
 k8s.io/code-generator v0.0.0-20180621065459-6702109cc68e/go.mod h1:MYiN+ZJZ9HkETbgVZdWw2AsuAi9PZ4V80cwfuf2axe8=
 k8s.io/gengo v0.0.0-20180718083919-906d99f89cd6/go.mod h1:ezvh/TsK7cY6rbqRK0oQQ8IAqLxYwwyPxAX1Pzy0ii0=

Should we just stop checking go.sums into source control? They seem to be a constant hassle.

@jglick
Copy link
Contributor

jglick commented Jan 25, 2019

Sounds like golang/go#27925 and the constellation of related issues. I removed the offending line from go.sum, did a go clean -modcache, and did a new build, but now I have a far larger diff, including apparently unrelated things in go.mod like

-	github.com/jenkins-x/jx v1.3.445
+	github.com/jenkins-x/jx v1.3.807

WTF?

@jenkins-x-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: jglick

If they are not already assigned, you can assign the PR to them by writing /assign @jglick in a comment when ready.

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@deanesmith deanesmith merged commit 0db4176 into master Jan 25, 2019
@deanesmith
Copy link
Contributor Author

/retest

@jenkins-x-bot
Copy link
Contributor

@deanesmith: The following test failed, say /retest to rerun them all:

Test name Commit Details Rerun command
serverless-jenkins 7bd1bba link /test this

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@deanesmith
Copy link
Contributor Author

/assign @jglick

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants