Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

--default-environments false gets ignored on AWS #692

Closed
sauravdevops opened this issue Apr 23, 2018 · 1 comment

Comments

Projects
None yet
2 participants
@sauravdevops
Copy link

commented Apr 23, 2018

What is happening

When passing the optional parameters to disable the default environments on AWS, its ignoring the false boolean value.

jx create cluster aws \
--cluster-name jxtest \
--domain tools.something.co.nz \
--default-environments false \
--git-username sauravdevops \
--nodes 3

Workaround
As suggested by @rawlingsj in the slack channel #jenkins-x-user used an = and its working!!
Created an Issue here if anyone else is facing similar issue or if it can be looked into or replicated for other platforms.

--default-environments=false 
@jstrachan

This comment has been minimized.

Copy link
Member

commented Apr 23, 2018

I guess this is a quirk of the CLI parser; it treats --default-environments as being a true flag - so it interprets --deafult-environments false as being --deafult-environments=true false - i.e. the false is treated as a CLI argument.

So maybe we should avoid having true default value options to avoid this kind of confusion? e.g. add a --no-default-environments instead?

@jstrachan jstrachan closed this in 619046b Apr 23, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.