New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix:(install) add promt for Jenkins installation type if prow or batch mode is not selected #2053

Merged
merged 5 commits into from Oct 23, 2018

Conversation

Projects
None yet
2 participants
@ccojocar
Copy link
Member

ccojocar commented Oct 21, 2018

No description provided.

@jenkins-x-bot jenkins-x-bot requested review from i0n and pmuir Oct 21, 2018

@ccojocar ccojocar requested review from jstrachan and rawlingsj and removed request for i0n and pmuir Oct 21, 2018

@ccojocar

This comment has been minimized.

Copy link
Member

ccojocar commented Oct 21, 2018

/test bdd

@ccojocar

This comment has been minimized.

Copy link
Member

ccojocar commented Oct 22, 2018

/test bdd

1 similar comment
@ccojocar

This comment has been minimized.

Copy link
Member

ccojocar commented Oct 22, 2018

/test bdd

@ccojocar

This comment has been minimized.

Copy link
Member

ccojocar commented Oct 23, 2018

/test bdd

@ccojocar

This comment has been minimized.

Copy link
Member

ccojocar commented Oct 23, 2018

/approve

@jenkins-x-bot

This comment has been minimized.

Copy link
Contributor

jenkins-x-bot commented Oct 23, 2018

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ccojocar

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ccojocar

This comment has been minimized.

Copy link
Member

ccojocar commented Oct 23, 2018

/test bdd

@jenkins-x-bot jenkins-x-bot merged commit 9629d1d into jenkins-x:master Oct 23, 2018

1 of 2 checks passed

tide Not mergeable. Job serverless-jenkins has not succeeded.
Details
serverless-jenkins succeeded
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment