New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add binary plugins #2104

Merged
merged 4 commits into from Nov 30, 2018

Conversation

Projects
None yet
6 participants
@pmuir
Copy link
Member

pmuir commented Oct 27, 2018

Binary plugins in jx behave exactly like binary plugins in kubectl, see
https://kubernetes.io/docs/tasks/extend-kubectl/kubectl-plugins/

Show resolved Hide resolved go.mod Outdated
return nil
}

func (o *PluginListOptions) Run() error {

This comment has been minimized.

@ccojocar

ccojocar Oct 28, 2018

Member

It would be nice to have a test for this.

@pmuir

This comment has been minimized.

Copy link
Member

pmuir commented Oct 30, 2018

/hold

Putting this explicitly on hold as I need to come back to this in a couple of days :-D

@pmuir

This comment has been minimized.

Copy link
Member

pmuir commented Nov 28, 2018

/hold cancel

@pmuir pmuir force-pushed the pmuir:plugins branch from 960e5ee to f5b52f9 Nov 28, 2018

Show resolved Hide resolved pkg/jx/cmd/templates/command_groups.go
Show resolved Hide resolved pkg/jx/cmd/templates/command_groups.go
Show resolved Hide resolved pkg/jx/cmd/templates/command_groups.go
Show resolved Hide resolved pkg/jx/cmd/get_plugins.go Outdated
Show resolved Hide resolved pkg/jx/cmd/get_plugins.go
Show resolved Hide resolved pkg/jx/cmd/common_plugins.go Outdated
Show resolved Hide resolved pkg/jx/cmd/cmd.go Outdated
Show resolved Hide resolved pkg/gits/provider.go Outdated
Show resolved Hide resolved pkg/gits/provider.go
Show resolved Hide resolved pkg/extensions/plugins.go Outdated
Show resolved Hide resolved pkg/extensions/plugins.go Outdated
Show resolved Hide resolved pkg/extensions/plugins.go
Show resolved Hide resolved pkg/extensions/plugins.go
Show resolved Hide resolved pkg/extensions/plugins.go Outdated
Show resolved Hide resolved pkg/extensions/plugins.go
Show resolved Hide resolved pkg/util/dirs.go
Show resolved Hide resolved pkg/log/log.go
Show resolved Hide resolved pkg/jx/cmd/templates/templater.go
Show resolved Hide resolved pkg/apis/jenkins.io/v1/types_extensions.go Outdated
Show resolved Hide resolved pkg/apis/jenkins.io/v1/types_extensions.go Outdated
Show resolved Hide resolved pkg/extensions/plugins.go Outdated
@jstrachan

This comment has been minimized.

Copy link
Member

jstrachan commented Nov 28, 2018

/lgtm

@@ -41,6 +42,11 @@ func Error(msg string) {
color.Red(msg)
}

// Prints an error msg with a new line at the end

This comment has been minimized.

@houndci-bot

houndci-bot Nov 28, 2018

Collaborator

comment on exported function Errorln should be of the form "Errorln ..."

@ccojocar

This comment has been minimized.

Copy link
Member

ccojocar commented Nov 29, 2018

/test bdd

1 similar comment
@pmuir

This comment has been minimized.

Copy link
Member

pmuir commented Nov 29, 2018

/test bdd

@pmuir pmuir force-pushed the pmuir:plugins branch from 42e1aff to 1afaffc Nov 29, 2018

@pmuir

This comment has been minimized.

Copy link
Member

pmuir commented Nov 29, 2018

/test bdd

@pmuir pmuir force-pushed the pmuir:plugins branch 4 times, most recently from 35f9776 to 2f4141d Nov 29, 2018

@pmuir

This comment has been minimized.

Copy link
Member

pmuir commented Nov 29, 2018

/test bdd

@pmuir pmuir force-pushed the pmuir:plugins branch from 2f4141d to bd57456 Nov 30, 2018

pmuir added some commits Oct 27, 2018

feat: add binary plugins
Binary plugins in jx behave exactly like binary plugins in kubectl, see 
https://kubernetes.io/docs/tasks/extend-kubectl/kubectl-plugins/
feat: distribute plugins via apps
* Add `jx get plugins` command
* Add plugins to app definitions & repositories
* Create Plugin CRD and add plugins to it when extensions are installed
* Automatically install app-managed plugins when called
* Display plugins in `jx help`
* Support for multiple platforms

pmuir added some commits Nov 28, 2018

chore: add DEBUG flag to Makefile
for example add `export DEBUG=1` to your `.bashrc`
to always enable debug flags locally

@pmuir pmuir force-pushed the pmuir:plugins branch from bd57456 to 072812d Nov 30, 2018

@pmuir

This comment has been minimized.

Copy link
Member

pmuir commented Nov 30, 2018

/test bdd

@rawlingsj

This comment has been minimized.

Copy link
Member

rawlingsj commented Nov 30, 2018

/lgtm

@jenkins-x-bot

This comment has been minimized.

Copy link
Contributor

jenkins-x-bot commented Nov 30, 2018

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jstrachan, rawlingsj

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [jstrachan,rawlingsj]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jenkins-x-bot jenkins-x-bot merged commit d1fee47 into jenkins-x:master Nov 30, 2018

2 of 3 checks passed

tide Not mergeable. Needs updatebot label.
Details
Hound 7 violations found.
serverless-jenkins succeeded
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment