test(git provider): add tests for git providers creation from URL

[ccojocar]

No description provided.

[ccojocar]

/test bdd

[ccojocar]

/test bdd

[ccojocar]

/test bdd

[rawlingsj]

/test bdd

[rawlingsj]

/test bdd

[rawlingsj]

ok this is building now

[rawlingsj]

/approve

[jenkins-x-bot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rawlingsj

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [rawlingsj]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[ccojocar]

@rawlingsj Thanks! The tests seem to failed because of the secret masking:

expected: auth.UserAuth{Username:"test", ApiToken:"test", BearerToken:"", Password:""} actual : auth.UserAuth{Username:"****", ApiToken:"****", BearerToken:"", Password:""}

Any idea how can I disable it during tests?

[rawlingsj]

Thanks! The tests seem to failed because of the secret masking:
Any idea how can I disable it during tests?

Ah I see, hmm I'm afraid I dont, @jtnord might have an idea?

[jtnord]

If you are using credentials then you can't not mask them, it's by design to prevent actual leaking. Why do bdd tests care about console output? Surely there is a mock git server that only accepts specific user/pass combinations and then you just care you could clone it so whatever operation was needed? Jenkins project has some simple git server docker that is used for its ATH...

[ccojocar]

/test bdd