New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: Add an app CRD #2304

Merged
merged 1 commit into from Nov 27, 2018

Conversation

@pmuir
Copy link
Member

pmuir commented Nov 22, 2018

Submitter checklist

  • Change is code complete and matches issue description.
  • Change is covered by existing or new tests.

Description

  • support for exposing services (using expose controller)
    by adding element to CRD
  • refactor exposecontroller logic out of commands

Special notes for the reviewer(s)

Which issue this PR fixes

fixes #

Show resolved Hide resolved pkg/jx/cmd/common_app.go
Show resolved Hide resolved pkg/helm/helm_helpers.go
Show resolved Hide resolved pkg/helm/helm_helpers.go
Show resolved Hide resolved pkg/extensions/hooks.go Outdated
Show resolved Hide resolved pkg/expose/exposecontroller.go
Show resolved Hide resolved pkg/expose/exposecontroller.go Outdated

@pmuir pmuir force-pushed the pmuir:apps_crd branch 2 times, most recently from 324f150 to 993e17d Nov 22, 2018

@pmuir

This comment has been minimized.

Copy link
Member

pmuir commented Nov 22, 2018

Here's an example of an app that uses the exposedServices: feature https://github.com/jenkins-x-apps/jx-app-grafana

@pmuir pmuir force-pushed the pmuir:apps_crd branch 5 times, most recently from afda5ab to 276a324 Nov 22, 2018

@pmuir pmuir changed the title WIP: Add an app CRD Feat: Add an app CRD Nov 22, 2018

@pmuir

This comment has been minimized.

Copy link
Member

pmuir commented Nov 23, 2018

feat: Add an app CRD
* support for exposing services (using expose controller)
  by adding element to CRD
* refactor exposecontroller logic out of commands
* An example of an app that uses the exposing services
  feature is https://github.com/jenkins-x-apps/jx-app-grafana
  - specifically see https://github.com/jenkins-x-apps/jx-app-grafana/blob/master/charts/jx-app-grafana/values.yaml#L1-L2 and
  https://github.com/jenkins-x-apps/jx-app-grafana/blob/master/charts/jx-app-grafana/templates/app.yaml

@pmuir pmuir force-pushed the pmuir:apps_crd branch from 276a324 to 81ea04b Nov 27, 2018

@jstrachan

This comment has been minimized.

Copy link
Member

jstrachan commented Nov 27, 2018

/lgtm

@jenkins-x-bot jenkins-x-bot added the lgtm label Nov 27, 2018

@garethjevans

This comment has been minimized.

Copy link
Member

garethjevans commented Nov 27, 2018

/lgtm

@jenkins-x-bot

This comment has been minimized.

Copy link
Contributor

jenkins-x-bot commented Nov 27, 2018

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: garethjevans, jstrachan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [garethjevans,jstrachan]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jenkins-x-bot jenkins-x-bot merged commit d687df7 into jenkins-x:master Nov 27, 2018

3 checks passed

Hound 1 violation found.
serverless-jenkins succeeded
tide In merge pool.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment