New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Making a few more commands possible to run w/o being cluster admin #2314

Merged
merged 5 commits into from Nov 27, 2018

Conversation

Projects
None yet
5 participants
@msvticket
Copy link
Contributor

msvticket commented Nov 23, 2018

Submitter checklist

  • Change is covered by existing or new tests.

Description

Here a are a few more fixes to enable a non cluster admin running commands that would be common or at least reasonable for such user to run.

Special notes for the reviewer(s)

Since all CRDs are registered in install.go, step_env_apply.go and upgrade_platform.go it should be safe to stop doing it elsewhere. I haven't written any new tests since no new functionality is added.

@jstrachan

This comment has been minimized.

Copy link
Member

jstrachan commented Nov 25, 2018

/ok-to-test
/test bdd
/approve

@rawlingsj

This comment has been minimized.

Copy link
Member

rawlingsj commented Nov 25, 2018

Looks like an integration test failure:

Found pipeline YAML /builder/home/.jx/draft/packs/github.com/jenkins-x-buildpacks/jenkins-x-kubernetes/packs/maven/pipeline.yaml and template file /builder/home/.jx/draft/packs/github.com/jenkins-x-buildpacks/jenkins-x-classic/packs/Jenkinsfile.tmpl
--- FAIL: TestStepBuildPackApply (1.91s)
    require.go:794:
        	Error Trace:	step_buildpack_apply_integration_test.go:74
        	Error:      	Received unexpected error:
        	            	template: myJenkinsfile:42:17: executing "myJenkinsfile" at <.Pipelines.Post.Groo...>: can't evaluate field Post in type jenkinsfile.Pipelines
        	            	failed to write file /tmp/test-step-buildpack-apply517403180/Jenkinsfile
        	            	github.com/jenkins-x/jx/pkg/jenkinsfile.(*CreateJenkinsfileArguments).GenerateJenkinsfile
        	            		/home/jenkins/go/src/github.com/jenkins-x/jx/pkg/jenkinsfile/pipeline.go:473
        	            	github.com/jenkins-x/jx/pkg/jx/cmd.(*CommonOptions).invokeDraftPack
        	            		/home/jenkins/go/src/github.com/jenkins-x/jx/pkg/jx/cmd/common_buildpacks.go:241
        	            	github.com/jenkins-x/jx/pkg/jx/cmd.(*StepBuildPackApplyOptions).Run
        	            		/home/jenkins/go/src/github.com/jenkins-x/jx/pkg/jx/cmd/step_buildpack_apply.go:103
        	            	github.com/jenkins-x/jx/pkg/jx/cmd_test.TestStepBuildPackApply
        	            		/home/jenkins/go/src/github.com/jenkins-x/jx/pkg/jx/cmd/step_buildpack_apply_integration_test.go:73
        	            	testing.tRunner
        	            		/usr/local/go/src/testing/testing.go:827
        	            	runtime.goexit
        	            		/usr/local/go/src/runtime/asm_amd64.s:1333
        	Test:       	TestStepBuildPackApply
        	Messages:   	failed to run step
helm installed and configured
@msvticket

This comment has been minimized.

Copy link
Contributor

msvticket commented Nov 26, 2018

/test bdd

@msvticket

This comment has been minimized.

Copy link
Contributor

msvticket commented Nov 26, 2018

Maybe I lack imagination, but I can't see the connection between my changes and the integration test failure. Flaky test? Retesting.

@msvticket

This comment has been minimized.

Copy link
Contributor

msvticket commented Nov 27, 2018

The integration tests have gone through a couple of times now.

@ccojocar

This comment has been minimized.

Copy link
Member

ccojocar commented Nov 27, 2018

/retest
/lgtm

@jenkins-x-bot

This comment has been minimized.

Copy link
Contributor

jenkins-x-bot commented Nov 27, 2018

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ccojocar, jstrachan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jenkins-x-bot jenkins-x-bot merged commit 2cae2df into jenkins-x:master Nov 27, 2018

3 checks passed

Hound No violations found. Woof!
serverless-jenkins succeeded
tide In merge pool.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment