New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: ensure gcloud is installed before login #2317

Merged
merged 2 commits into from Nov 23, 2018

Conversation

Projects
None yet
4 participants
@garethjevans
Copy link
Member

garethjevans commented Nov 23, 2018

  • Change is code complete and matches issue description.
  • Change is covered by existing or new tests.

fixes #

@jenkins-x-bot jenkins-x-bot requested review from jtnord and markawm Nov 23, 2018

@garethjevans

This comment has been minimized.

Copy link
Member

garethjevans commented Nov 23, 2018

Fixes #2316

@garethjevans

This comment has been minimized.

Copy link
Member

garethjevans commented Nov 23, 2018

/assign @romainverduci

@romainverduci

This comment has been minimized.

Copy link
Member

romainverduci commented Nov 23, 2018

/lgtm

@jenkins-x-bot jenkins-x-bot added the lgtm label Nov 23, 2018

@rawlingsj

This comment has been minimized.

Copy link
Member

rawlingsj commented Nov 23, 2018

/approve

@jenkins-x-bot

This comment has been minimized.

Copy link
Contributor

jenkins-x-bot commented Nov 23, 2018

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rawlingsj, romainverduci

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jenkins-x-bot jenkins-x-bot merged commit 90d0abb into jenkins-x:master Nov 23, 2018

2 of 3 checks passed

tide Not mergeable.
Details
Hound No violations found. Woof!
serverless-jenkins succeeded
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment