New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a basic unit test for PreviewOptions #2319

Merged
merged 19 commits into from Nov 27, 2018

Conversation

Projects
None yet
4 participants
@markawm
Copy link
Member

markawm commented Nov 23, 2018

Submitter checklist

  • Change is code complete and matches issue description.
  • Change is covered by existing or new tests.

Description

Adding a basic unit test for PreviewOptions. There are many more tests that could be written as there are quite a few conditional code branches in the large Run() method - this just gives a basic 'happy-path' validation of the functionality. Still todo:

  • break up the Run() method & unit test.
  • add more tests for the various conditional paths (which will be a lot easier once the functionality is more modular).

Special notes for the reviewer(s)

Which issue this PR fixes

fixes #

prAuthor = "the-pr-author"
prOwner = "the-pr-owner"
prEmail = "the-pr-owner@organisation.com"
userK8sId = "the-pr-owner.organisation.com"

This comment has been minimized.

@houndci-bot

houndci-bot Nov 23, 2018

Collaborator

const userK8sId should be userK8sID

markawm and others added some commits Nov 23, 2018

@jenkins-x-bot

This comment has been minimized.

Copy link
Contributor

jenkins-x-bot commented Nov 27, 2018

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ccojocar

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jenkins-x-bot jenkins-x-bot merged commit bf776c2 into jenkins-x:master Nov 27, 2018

3 checks passed

Hound No violations found. Woof!
serverless-jenkins succeeded
tide In merge pool.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment