New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: lets use a more explicit label for the default workloads #2326

Merged
merged 1 commit into from Nov 26, 2018

Conversation

Projects
None yet
3 participants
@jstrachan
Copy link
Member

jstrachan commented Nov 26, 2018

No description provided.

@jenkins-x-bot jenkins-x-bot requested review from pmuir and rawlingsj Nov 26, 2018

@jstrachan

This comment has been minimized.

Copy link
Member

jstrachan commented Nov 26, 2018

/lgtm

@jenkins-x-bot

This comment has been minimized.

Copy link
Contributor

jenkins-x-bot commented Nov 26, 2018

@jstrachan: you cannot LGTM your own PR.

In response to this:

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@rawlingsj

This comment has been minimized.

Copy link
Member

rawlingsj commented Nov 26, 2018

/lgtm

@jenkins-x-bot

This comment has been minimized.

Copy link
Contributor

jenkins-x-bot commented Nov 26, 2018

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jstrachan, rawlingsj

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [jstrachan,rawlingsj]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jenkins-x-bot jenkins-x-bot merged commit 545950a into jenkins-x:master Nov 26, 2018

2 of 3 checks passed

tide Not mergeable. Needs updatebot label.
Details
Hound No violations found. Woof!
serverless-jenkins succeeded
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment