New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(get pipelines): don't ask for an API token #2328

Merged
merged 5 commits into from Nov 28, 2018

Conversation

Projects
None yet
4 participants
@amuniz
Copy link
Member

amuniz commented Nov 26, 2018

When Prow and KNative builds are enabled there is no Jenkins to ask for pipelines. jx get pipelines returns now the list of release jobs, to be consistent with jx start pipeline.

Submitter checklist

  • Change is code complete and matches issue description.
  • Change is covered by existing or new tests.

Description

This fix avoid the API Token requirement on jx get pipelines when using knative builds, and also makes the output of jx get pipelines consistent with jx start pipeline.

Name                                     URL LAST_BUILD STATUS DURATION
jenkins-x/dummy/master                   N/A N/A        N/A    N/A

Special notes for the reviewer(s)

Which issue this PR fixes

fixes #2327 (PLAT-259)

fix(get pipelines): don't ask for an API token
When Prow and KNative builds are enabled there is no Jenkins to ask for pipelines. `jx get pipelines` returns now the list of release jobs, to be consistent with `jx start pipeline`.

@jenkins-x-bot jenkins-x-bot requested review from jtnord and wbrefvem Nov 26, 2018

@jtnord
Copy link
Member

jtnord left a comment

/lgtm

@amuniz

This comment has been minimized.

Copy link
Member

amuniz commented Nov 27, 2018

/retest

@amuniz

This comment has been minimized.

Copy link
Member

amuniz commented Nov 27, 2018

Test failure is:

--- FAIL: TestStepBuildPackApply (1.94s)
    require.go:794: 
        	Error Trace:	step_buildpack_apply_integration_test.go:74
        	Error:      	Received unexpected error:
        	            	template: myJenkinsfile:42:17: executing "myJenkinsfile" at <.Pipelines.Post.Groo...>: can't evaluate field Post in type jenkinsfile.Pipelines
        	            	failed to write file /tmp/test-step-buildpack-apply123564351/Jenkinsfile
        	            	github.com/jenkins-x/jx/pkg/jenkinsfile.(*CreateJenkinsfileArguments).GenerateJenkinsfile
        	            		/home/jenkins/go/src/github.com/jenkins-x/jx/pkg/jenkinsfile/pipeline.go:473
        	            	github.com/jenkins-x/jx/pkg/jx/cmd.(*CommonOptions).invokeDraftPack
        	            		/home/jenkins/go/src/github.com/jenkins-x/jx/pkg/jx/cmd/common_buildpacks.go:241
        	            	github.com/jenkins-x/jx/pkg/jx/cmd.(*StepBuildPackApplyOptions).Run
        	            		/home/jenkins/go/src/github.com/jenkins-x/jx/pkg/jx/cmd/step_buildpack_apply.go:103
        	            	github.com/jenkins-x/jx/pkg/jx/cmd_test.TestStepBuildPackApply
        	            		/home/jenkins/go/src/github.com/jenkins-x/jx/pkg/jx/cmd/step_buildpack_apply_integration_test.go:73
        	            	testing.tRunner
        	            		/usr/local/go/src/testing/testing.go:827
        	            	runtime.goexit
        	            		/usr/local/go/src/runtime/asm_amd64.s:1333
        	Test:       	TestStepBuildPackApply
        	Messages:   	failed to run step

I don't think it is related to this PR, @jstrachan?

Show resolved Hide resolved pkg/jx/cmd/get_pipeline.go
Show resolved Hide resolved pkg/jx/cmd/get_pipeline.go

@jenkins-x-bot jenkins-x-bot removed the lgtm label Nov 27, 2018

@ccojocar

This comment has been minimized.

Copy link
Member

ccojocar commented Nov 27, 2018

/test bdd

@ccojocar

This comment has been minimized.

Copy link
Member

ccojocar commented Nov 27, 2018

/retest

amuniz added some commits Nov 27, 2018

@amuniz

This comment has been minimized.

Copy link
Member

amuniz commented Nov 28, 2018

@ccojocar something blocking the approval? /cc @jstrachan

@jenkins-x-bot

This comment has been minimized.

Copy link
Contributor

jenkins-x-bot commented Nov 28, 2018

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ccojocar, jtnord

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jenkins-x-bot jenkins-x-bot merged commit ea208e7 into jenkins-x:master Nov 28, 2018

3 checks passed

Hound No violations found. Woof!
serverless-jenkins succeeded
tide In merge pool.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment