New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Create API token on promote if needed #2332

Merged
merged 2 commits into from Nov 27, 2018

Conversation

Projects
None yet
3 participants
@msvticket
Copy link
Contributor

msvticket commented Nov 26, 2018

Submitter checklist

  • Change is covered by existing or new tests.

Description

This fixes error on promote without configured api tokens: POST https://api.github.com/repos/org/environment/pulls: 401 Bad credentials []

There is a bit of cleanup in related code.
Will also solve other cases of missing api tokens.

Special notes for the reviewer(s)

I think any additional tests would need to be integration tests. But I haven't written any since it's difficult for me to do without access to the test environment.

Fix: Create API token on promote if needed
This fixes error: POST https://api.github.com/repos/org/environment/pulls: 401 Bad credentials []
Also a bit of cleanup in related code.

@jenkins-x-bot jenkins-x-bot added approved and removed lgtm labels Nov 27, 2018

@ccojocar

This comment has been minimized.

Copy link
Member

ccojocar commented Nov 27, 2018

/test bdd
/lgtm
/approve

@jenkins-x-bot jenkins-x-bot added the lgtm label Nov 27, 2018

@jenkins-x-bot

This comment has been minimized.

Copy link
Contributor

jenkins-x-bot commented Nov 27, 2018

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ccojocar

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ccojocar

This comment has been minimized.

Copy link
Member

ccojocar commented Nov 27, 2018

/ok-to-test

@jenkins-x-bot jenkins-x-bot merged commit fa97ac5 into jenkins-x:master Nov 27, 2018

3 checks passed

Hound No violations found. Woof!
serverless-jenkins succeeded
tide In merge pool.
Details

@msvticket msvticket deleted the deniedboarding:git_api_token_promote branch Nov 27, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment