New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Add domain name validation when configuring ingress to loadbalancer #2334

Merged
merged 8 commits into from Nov 27, 2018

Conversation

Projects
None yet
4 participants
@mikecirioli
Copy link
Member

mikecirioli commented Nov 26, 2018

Submitter checklist

  • Change is code complete and matches issue description.
  • Change is covered by existing or new tests.

Description

Adds simple domain name validation (domain names must not contain any whitespace) when configuring LB ingress during installation. Also adds unit test for NoWhiteSpaceValidator

Special notes for the reviewer(s)

Which issue this PR fixes

fixes #

mikecirioli added some commits Nov 26, 2018

fix: Add validation to check if user is trying to configure DNS domain
with an invalid value that contains whitespace

@jenkins-x-bot jenkins-x-bot requested review from markawm and rawlingsj Nov 26, 2018

Show resolved Hide resolved pkg/jx/cmd/init_test.go Outdated
Show resolved Hide resolved pkg/jx/cmd/init.go Outdated
Show resolved Hide resolved pkg/jx/cmd/init.go Outdated
@ccojocar

This comment has been minimized.

Copy link
Member

ccojocar commented Nov 27, 2018

/test bdd

@jenkins-x-bot jenkins-x-bot removed the lgtm label Nov 27, 2018

@ccojocar

This comment has been minimized.

Copy link
Member

ccojocar commented Nov 27, 2018

/retest

mikecirioli added some commits Nov 27, 2018

@jenkins-x-bot jenkins-x-bot added the lgtm label Nov 27, 2018

@ccojocar

This comment has been minimized.

Copy link
Member

ccojocar commented Nov 27, 2018

/lgtm
/approve

@jenkins-x-bot

This comment has been minimized.

Copy link
Contributor

jenkins-x-bot commented Nov 27, 2018

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ccojocar

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jenkins-x-bot jenkins-x-bot merged commit aafa006 into jenkins-x:master Nov 27, 2018

3 checks passed

Hound No violations found. Woof!
serverless-jenkins Job succeeded.
tide In merge pool.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment