New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix username is not set correctly for Openshift provider #2337

Merged
merged 2 commits into from Nov 27, 2018

Conversation

Projects
None yet
3 participants
@daveconde
Copy link
Contributor

daveconde commented Nov 27, 2018

Fixes #2109 - It now uses a bearer token for the jenkins service account.

@jstrachan

This comment has been minimized.

Copy link
Member

jstrachan commented Nov 27, 2018

/ok-to-test
/test bdd

@jstrachan

This comment has been minimized.

Copy link
Member

jstrachan commented Nov 27, 2018

/approve

@jstrachan

This comment has been minimized.

Copy link
Member

jstrachan commented Nov 27, 2018

/lgtm

@jenkins-x-bot

This comment has been minimized.

Copy link
Contributor

jenkins-x-bot commented Nov 27, 2018

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jstrachan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jenkins-x-bot jenkins-x-bot merged commit 2b6a15f into jenkins-x:master Nov 27, 2018

3 checks passed

Hound No violations found. Woof!
serverless-jenkins succeeded
tide In merge pool.
Details

@daveconde daveconde deleted the daveconde:openshift-fix-jenkins-username branch Nov 27, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment