New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(gke): do not run in parallel the tests which mocks the same method #2341

Merged
merged 7 commits into from Nov 28, 2018

Conversation

Projects
None yet
3 participants
@ccojocar
Copy link
Member

ccojocar commented Nov 27, 2018

It seems that pegomock has a concurrency issue in this case, which leads
to random failures.

Submitter checklist

  • Change is code complete and matches issue description.
  • Change is covered by existing or new tests.

Description

Special notes for the reviewer(s)

Which issue this PR fixes

fixes #

test(gke): do not run in parallel the tests which mock the same method
It seems that pegomock has a concurrency issue in this case, which leads
to random failures.

@jenkins-x-bot jenkins-x-bot requested review from mikecirioli and wbrefvem Nov 27, 2018

@ccojocar ccojocar requested a review from agentgonzo Nov 27, 2018

@jenkins-x-bot jenkins-x-bot removed the lgtm label Nov 27, 2018

@jenkins-x-bot jenkins-x-bot added the lgtm label Nov 27, 2018

@jenkins-x-bot jenkins-x-bot removed the lgtm label Nov 27, 2018

@ccojocar

This comment has been minimized.

Copy link
Member

ccojocar commented Nov 27, 2018

/retest

@ccojocar ccojocar changed the title test(gke): do not run in parallel the tests which mock the same method test(gke): do not run in parallel the tests which mocks the same method Nov 27, 2018

@ccojocar

This comment has been minimized.

Copy link
Member

ccojocar commented Nov 27, 2018

/retest

@ccojocar

This comment has been minimized.

Copy link
Member

ccojocar commented Nov 28, 2018

/retest

@ccojocar

This comment has been minimized.

Copy link
Member

ccojocar commented Nov 28, 2018

/retest

@jenkins-x-bot jenkins-x-bot added the lgtm label Nov 28, 2018

@jenkins-x-bot

This comment has been minimized.

Copy link
Contributor

jenkins-x-bot commented Nov 28, 2018

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: agentgonzo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ccojocar ccojocar merged commit b56f111 into jenkins-x:master Nov 28, 2018

2 of 3 checks passed

serverless-jenkins Building
Hound No violations found. Woof!
tide In merge pool.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment