New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(login) let's make sure users that haven't installed or created the cluster have the base set of binaries installed fixes #2300 #2345

Merged
merged 1 commit into from Nov 27, 2018

Conversation

Projects
None yet
3 participants
@rawlingsj
Copy link
Member

rawlingsj commented Nov 27, 2018

No description provided.

fix(login) let's make sure users that haven't installed or created th…
…e cluster have the base set of binaries installed fixes #2300

@jenkins-x-bot jenkins-x-bot requested review from ccojocar and jtnord Nov 27, 2018

@garethjevans

This comment has been minimized.

Copy link
Member

garethjevans commented Nov 27, 2018

/lgtm

@jenkins-x-bot

This comment has been minimized.

Copy link
Contributor

jenkins-x-bot commented Nov 27, 2018

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: garethjevans

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jenkins-x-bot jenkins-x-bot merged commit a2a1f2e into jenkins-x:master Nov 27, 2018

3 checks passed

Hound No violations found. Woof!
serverless-jenkins succeeded
tide In merge pool.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment