New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use an A Record rather than CNAME #2347

Merged
merged 2 commits into from Nov 28, 2018

Conversation

Projects
None yet
3 participants
@agentgonzo
Copy link
Member

agentgonzo commented Nov 27, 2018

No point in using a CNAME referring to a .nip.io address. You may as well just use an A Record

Submitter checklist

  • Change is code complete and matches issue description.
  • Change is covered by existing or new tests.

Description

Special notes for the reviewer(s)

Which issue this PR fixes

fixes #

Use an A Record rather than CNAME
No point in using a CNAME referring to a .nip.io address. You may as well just use an A Record

@jenkins-x-bot jenkins-x-bot requested review from rajdavies and wbrefvem Nov 27, 2018

@agentgonzo agentgonzo requested review from jstrachan and jtnord and removed request for rajdavies Nov 27, 2018

@jenkins-x-bot

This comment has been minimized.

Copy link
Contributor

jenkins-x-bot commented Nov 28, 2018

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ccojocar

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ccojocar

This comment has been minimized.

Copy link
Member

ccojocar commented Nov 28, 2018

/test bdd

@jenkins-x-bot jenkins-x-bot merged commit a4ec5ac into master Nov 28, 2018

3 checks passed

Hound No violations found. Woof!
serverless-jenkins succeeded
tide In merge pool.
Details

@agentgonzo agentgonzo deleted the DNS-records branch Nov 29, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment