New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Import from non dev team namespace #2354

Merged
merged 1 commit into from Nov 28, 2018

Conversation

Projects
None yet
3 participants
@msvticket
Copy link
Contributor

msvticket commented Nov 28, 2018

This fixes a regression appearing with the introduction of prow that made
import and other commands calling ImportOptions.Run with another team
namespace than dev as the current namespace fail with:

error: no environment with name 'dev' found

Submitter checklist

  • Change is covered by existing or new tests.
fix: Import from non dev team namespace
This fixes a regression appearing with the introduction of prow that made
import and other commands calling ImportOptions.Run with another team
namespace than dev as the current namespace fail with:

error: no environment with name 'dev' found
@jstrachan

This comment has been minimized.

Copy link
Member

jstrachan commented Nov 28, 2018

/ok-to-test
/test bdd
/approve

@jstrachan

This comment has been minimized.

Copy link
Member

jstrachan commented Nov 28, 2018

/lgtm

@jenkins-x-bot

This comment has been minimized.

Copy link
Contributor

jenkins-x-bot commented Nov 28, 2018

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jstrachan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jenkins-x-bot jenkins-x-bot merged commit 2a269e3 into jenkins-x:master Nov 28, 2018

3 checks passed

Hound No violations found. Woof!
serverless-jenkins succeeded
tide In merge pool.
Details

@msvticket msvticket deleted the deniedboarding:import-non-dev branch Nov 28, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment