New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(upgrade ingress): add a flag to skip the update of jx related resources #2358

Merged
merged 5 commits into from Nov 29, 2018

Conversation

Projects
None yet
3 participants
@ccojocar
Copy link
Member

ccojocar commented Nov 28, 2018

Submitter checklist

  • Change is code complete and matches issue description.
  • Change is covered by existing or new tests.

Description

Add a flag to skip the update of jx related resource in the 'upgrade ingress' command. This allows to run the command
before installing the jx platform. For instance when exposing the Vault used to stored the credentials.

Special notes for the reviewer(s)

Which issue this PR fixes

fixes #

@jenkins-x-bot jenkins-x-bot requested review from pmuir and rajdavies Nov 28, 2018

@ccojocar ccojocar requested review from rawlingsj and agentgonzo and removed request for pmuir and rajdavies Nov 28, 2018

@ccojocar

This comment has been minimized.

Copy link
Member

ccojocar commented Nov 28, 2018

/test bdd

@ccojocar

This comment has been minimized.

Copy link
Member

ccojocar commented Nov 29, 2018

/retest

@ccojocar

This comment has been minimized.

Copy link
Member

ccojocar commented Nov 29, 2018

/test bdd

@ccojocar

This comment has been minimized.

Copy link
Member

ccojocar commented Nov 29, 2018

/retest

@ccojocar ccojocar force-pushed the ccojocar:upgrade-ingress-without-jx-installed branch from 3e93d2b to ddbf0bd Nov 29, 2018

@ccojocar

This comment has been minimized.

Copy link
Member

ccojocar commented Nov 29, 2018

/test bdd

@ccojocar

This comment has been minimized.

Copy link
Member

ccojocar commented Nov 29, 2018

/retest

@ccojocar

This comment has been minimized.

Copy link
Member

ccojocar commented Nov 29, 2018

/lgtm

@jenkins-x-bot

This comment has been minimized.

Copy link
Contributor

jenkins-x-bot commented Nov 29, 2018

@ccojocar: you cannot LGTM your own PR.

In response to this:

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ccojocar

This comment has been minimized.

Copy link
Member

ccojocar commented Nov 29, 2018

/retest

@agentgonzo

This comment has been minimized.

Copy link
Member

agentgonzo commented Nov 29, 2018

/lgtm

@jenkins-x-bot jenkins-x-bot added the lgtm label Nov 29, 2018

@jenkins-x-bot

This comment has been minimized.

Copy link
Contributor

jenkins-x-bot commented Nov 29, 2018

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: agentgonzo, ccojocar

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [agentgonzo,ccojocar]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jenkins-x-bot jenkins-x-bot merged commit 9fcc90d into jenkins-x:master Nov 29, 2018

2 of 3 checks passed

tide Not mergeable. Needs updatebot label.
Details
Hound No violations found. Woof!
serverless-jenkins succeeded
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment