New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(vault): Added more error handling to vault #2361

Merged
merged 1 commit into from Nov 29, 2018

Conversation

Projects
None yet
3 participants
@agentgonzo
Copy link
Member

agentgonzo commented Nov 29, 2018

rather than getting a stacktrace, you now get on errors:

$ ./jx get vault-config
error: Error getting Vault signin token: Error making API request.

URL: PUT http://jx-vault.jx.35.187.37.181.nip.io/v1/auth/kubernetes/login
Code: 500. Errors:

* {"kind":"Status","apiVersion":"v1","metadata":{},"status":"Failure","message":"tokenreviews.authentication.k8s.io is forbidden: User \"system:serviceaccount:jx:default\" cannot create tokenreviews.authentication.k8s.io at the cluster scope","reason":"Forbidden","details":{"group":"authentication.k8s.io","kind":"tokenreviews"},"code":403}

@jenkins-x-bot jenkins-x-bot added the lgtm label Nov 29, 2018

@jenkins-x-bot

This comment has been minimized.

Copy link
Contributor

jenkins-x-bot commented Nov 29, 2018

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ccojocar

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jenkins-x-bot jenkins-x-bot merged commit 151e53e into jenkins-x:master Nov 29, 2018

3 checks passed

Hound No violations found. Woof!
serverless-jenkins succeeded
tide In merge pool.
Details

@agentgonzo agentgonzo deleted the agentgonzo:vault-errors branch Nov 29, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment