New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid panic on failed repo creation #2366

Merged
merged 2 commits into from Nov 29, 2018

Conversation

Projects
None yet
3 participants
@davidcurrie
Copy link
Member

davidcurrie commented Nov 29, 2018

Submitter checklist

  • [x ] Change is code complete and matches issue description.
  • Change is covered by existing or new tests.

Description

Re-order statements to avoid nil dereference

Which issue this PR fixes

fixes #2364

@jenkins-x-bot jenkins-x-bot requested review from jtnord and wbrefvem Nov 29, 2018

@jenkins-x-bot jenkins-x-bot added approved and removed lgtm labels Nov 29, 2018

@ccojocar

This comment has been minimized.

Copy link
Member

ccojocar commented Nov 29, 2018

/test bdd
/lgtm

@jenkins-x-bot jenkins-x-bot added the lgtm label Nov 29, 2018

@jenkins-x-bot

This comment has been minimized.

Copy link
Contributor

jenkins-x-bot commented Nov 29, 2018

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ccojocar

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jenkins-x-bot jenkins-x-bot merged commit c0074c8 into jenkins-x:master Nov 29, 2018

3 checks passed

Hound No violations found. Woof!
serverless-jenkins succeeded
tide In merge pool.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment