New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed Helm installation error handling #2369

Merged
merged 2 commits into from Nov 29, 2018

Conversation

Projects
None yet
4 participants
@hekonsek
Copy link
Contributor

hekonsek commented Nov 29, 2018

There are two return statements missing in Helm installation code. It leads to weird behavior if Helm initialization fails.

@jstrachan

This comment has been minimized.

Copy link
Member

jstrachan commented Nov 29, 2018

/ok-to-test

@jstrachan

This comment has been minimized.

Copy link
Member

jstrachan commented Nov 29, 2018

/lgtm

@jstrachan

This comment has been minimized.

Copy link
Member

jstrachan commented Nov 29, 2018

/retest

@jenkins-x-bot jenkins-x-bot removed the lgtm label Nov 29, 2018

@ccojocar

This comment has been minimized.

Copy link
Member

ccojocar commented Nov 29, 2018

/retest

@ccojocar

This comment has been minimized.

Copy link
Member

ccojocar commented Nov 29, 2018

/lgtm

@jenkins-x-bot

This comment has been minimized.

Copy link
Contributor

jenkins-x-bot commented Nov 29, 2018

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ccojocar, jstrachan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jenkins-x-bot jenkins-x-bot merged commit d0e7b1e into jenkins-x:master Nov 29, 2018

3 checks passed

Hound No violations found. Woof!
serverless-jenkins succeeded
tide In merge pool.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment