New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(vault): Store a flag in the jx-install-config to denote if secrets are to be stored in vault #2375

Merged
merged 6 commits into from Dec 2, 2018

Conversation

Projects
None yet
5 participants
@agentgonzo
Copy link
Member

agentgonzo commented Nov 29, 2018

If jx install --vault is run, secrets get stored in vault. With this PR, it will now update the jx-install-config configmap with a new entry: useVaultForSecrets: "true" that tells the client that secrets are stored in vault (as opposed to on the file systme).

This can (and is) queried by the client to determine whether to load the secrets from vault.

@jenkins-x-bot jenkins-x-bot requested review from amuniz and pmuir Nov 29, 2018

@agentgonzo agentgonzo requested a review from ccojocar Nov 29, 2018

@agentgonzo agentgonzo force-pushed the agentgonzo:vault-in-use-flag branch 2 times, most recently from 4e426af to 6134ccb Nov 29, 2018

Show resolved Hide resolved pkg/io/secrets/secret_locations.go Outdated
Show resolved Hide resolved pkg/io/secrets/secret_locations.go Outdated
Show resolved Hide resolved pkg/io/secrets/secret_locations.go Outdated
Show resolved Hide resolved pkg/io/secrets/secret_locations_test.go
Show resolved Hide resolved pkg/io/secrets/secret_locations.go Outdated
Show resolved Hide resolved pkg/io/secrets/secret_locations.go

@jenkins-x-bot jenkins-x-bot added lgtm approved and removed lgtm labels Nov 30, 2018

@ccojocar

This comment has been minimized.

Copy link
Member

ccojocar commented Nov 30, 2018

/lgtm

@jenkins-x-bot jenkins-x-bot added the lgtm label Nov 30, 2018

@ccojocar

This comment has been minimized.

Copy link
Member

ccojocar commented Nov 30, 2018

/retest

@jenkins-x-bot jenkins-x-bot removed the lgtm label Nov 30, 2018

@ccojocar

This comment has been minimized.

Copy link
Member

ccojocar commented Nov 30, 2018

/lgtm

@jenkins-x-bot jenkins-x-bot added lgtm and removed lgtm labels Nov 30, 2018

@jstrachan

This comment has been minimized.

Copy link
Member

jstrachan commented Dec 1, 2018

/lgtm

@ccojocar

This comment has been minimized.

Copy link
Member

ccojocar commented Dec 2, 2018

/retest

@ccojocar

This comment has been minimized.

Copy link
Member

ccojocar commented Dec 2, 2018

/lgtm

@jenkins-x-bot jenkins-x-bot added the lgtm label Dec 2, 2018

agentgonzo added some commits Nov 29, 2018

chore(quality): Refactored configmap code to make it neater
Initial import of Dev Environment source
feat(vault): use vault flag stored in cluster config for secret location
Lookup the flag (and cache it) from the jx-install-configmap to determine
whether secrets are stored in vault or not.

@ccojocar ccojocar force-pushed the agentgonzo:vault-in-use-flag branch from 9131517 to 228912b Dec 2, 2018

@jenkins-x-bot jenkins-x-bot removed the lgtm label Dec 2, 2018

@ccojocar

This comment has been minimized.

Copy link
Member

ccojocar commented Dec 2, 2018

/lgtm

1 similar comment
@ccojocar

This comment has been minimized.

Copy link
Member

ccojocar commented Dec 2, 2018

/lgtm

@jenkins-x-bot jenkins-x-bot added the lgtm label Dec 2, 2018

@jenkins-x-bot

This comment has been minimized.

Copy link
Contributor

jenkins-x-bot commented Dec 2, 2018

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ccojocar, jstrachan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jenkins-x-bot jenkins-x-bot merged commit 39b10ef into jenkins-x:master Dec 2, 2018

3 checks passed

Hound No violations found. Woof!
serverless-jenkins succeeded
tide In merge pool.
Details

@agentgonzo agentgonzo deleted the agentgonzo:vault-in-use-flag branch Dec 7, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment