New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug(install): Fix 'Brew' pre-req installation. #2382

Merged
merged 2 commits into from Dec 1, 2018

Conversation

Projects
None yet
4 participants
@markawm
Copy link
Member

markawm commented Nov 29, 2018

Submitter checklist

  • Change is code complete and matches issue description.
  • Change is covered by existing or new tests.

Description

If 'brew' was not installed, then "jx install" attempts to install it, but fails because the command uses shell expansion,
but no shell. Fixed by changing the command to be 'sh', and have that run the brew installation command.
(I guess as pretty much everyone already has brew this doesn't get exercised too often!)

Special notes for the reviewer(s)

Which issue this PR fixes

fixes #2377

@jenkins-x-bot jenkins-x-bot requested review from i0n and pmuir Nov 29, 2018

bug(install): Fix 'Brew' pre-req installation.
If 'brew' was not installed, then "jx install" attempts to install it, but fails because the command uses shell expansion,
but no shell. Fixed by changing the command to be 'sh', and have that run the brew installation command.
(I guess as pretty much everyone already has brew this doesn't get exercised too often!)

@markawm markawm force-pushed the markawm:brew-install-fail branch from 5a1203d to ecb7513 Nov 29, 2018

@ccojocar

This comment has been minimized.

Copy link
Member

ccojocar commented Nov 30, 2018

/test bdd

@jenkins-x-bot jenkins-x-bot removed the lgtm label Nov 30, 2018

@ccojocar

This comment has been minimized.

Copy link
Member

ccojocar commented Nov 30, 2018

/test bdd

@ccojocar

This comment has been minimized.

Copy link
Member

ccojocar commented Nov 30, 2018

/retest

@jstrachan

This comment has been minimized.

Copy link
Member

jstrachan commented Dec 1, 2018

/lgtm

@jenkins-x-bot

This comment has been minimized.

Copy link
Contributor

jenkins-x-bot commented Dec 1, 2018

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ccojocar, jstrachan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jenkins-x-bot jenkins-x-bot merged commit f0f7be5 into jenkins-x:master Dec 1, 2018

3 checks passed

Hound No violations found. Woof!
serverless-jenkins succeeded
tide In merge pool.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment