New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: expose results from `jx get app` in a better structure #2383

Merged
merged 1 commit into from Nov 30, 2018

Conversation

Projects
None yet
3 participants
@jstrachan
Copy link
Member

jstrachan commented Nov 30, 2018

we forgot to include the environment name as part of the tree.
this change helps us test apps hit staging/production in the bdd tests

chore: expose results from `jx get app` in a better structure
we forgot to include the environment name as part of the tree.
this change helps us test apps hit staging/production in the bdd tests

@jenkins-x-bot jenkins-x-bot requested review from i0n and markawm Nov 30, 2018

@jstrachan

This comment has been minimized.

Copy link
Member

jstrachan commented Nov 30, 2018

/retest

@jenkins-x-bot

This comment has been minimized.

Copy link
Contributor

jenkins-x-bot commented Nov 30, 2018

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ccojocar

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ccojocar

This comment has been minimized.

Copy link
Member

ccojocar commented Nov 30, 2018

/test bdd

@jenkins-x-bot jenkins-x-bot merged commit 7176dd7 into jenkins-x:master Nov 30, 2018

3 checks passed

Hound No violations found. Woof!
serverless-jenkins succeeded
tide In merge pool.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment