New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(tests): Windows tests fail #2384

Merged
merged 1 commit into from Nov 30, 2018

Conversation

Projects
None yet
3 participants
@agentgonzo
Copy link
Member

agentgonzo commented Nov 30, 2018

go-expect tests don't work on windows. Please remember this

Submitter checklist

  • Change is code complete and matches issue description.
  • Change is covered by existing or new tests.

Description

Special notes for the reviewer(s)

Which issue this PR fixes

fixes #

chore(tests): Windows tests fail
`go-expect` tests don't work on windows. Please remember this

@agentgonzo agentgonzo requested a review from ccojocar Nov 30, 2018

@jenkins-x-bot jenkins-x-bot requested review from i0n and rawlingsj Nov 30, 2018

@agentgonzo

This comment has been minimized.

Copy link
Member

agentgonzo commented Nov 30, 2018

/retest

@jenkins-x-bot

This comment has been minimized.

Copy link
Contributor

jenkins-x-bot commented Nov 30, 2018

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ccojocar

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ccojocar

This comment has been minimized.

Copy link
Member

ccojocar commented Nov 30, 2018

/retest

@jenkins-x-bot jenkins-x-bot merged commit 03281c6 into master Nov 30, 2018

3 checks passed

Hound No violations found. Woof!
serverless-jenkins succeeded
tide In merge pool.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment