New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improve CLI for no-tiller #2393

Merged
merged 12 commits into from Dec 4, 2018

Conversation

Projects
None yet
4 participants
@jstrachan
Copy link
Member

jstrachan commented Dec 3, 2018

No description provided.

@jenkins-x-bot jenkins-x-bot requested review from amuniz and i0n Dec 3, 2018

@jenkins-x-bot jenkins-x-bot added the size/L label Dec 3, 2018

Show resolved Hide resolved pkg/jx/cmd/step_helm_delete.go Outdated
Show resolved Hide resolved pkg/jx/cmd/step_helm_delete.go
Show resolved Hide resolved pkg/jx/cmd/step_helm_delete.go
Show resolved Hide resolved pkg/jx/cmd/step_helm_delete.go Outdated

jstrachan added some commits Dec 3, 2018

Show resolved Hide resolved pkg/jx/cmd/step_collect.go Outdated
@jstrachan

This comment has been minimized.

Copy link
Member

jstrachan commented Dec 3, 2018

/retest

1 similar comment
@jstrachan

This comment has been minimized.

Copy link
Member

jstrachan commented Dec 4, 2018

/retest

@jstrachan

This comment has been minimized.

Copy link
Member

jstrachan commented Dec 4, 2018

/test bdd

@jstrachan

This comment has been minimized.

Copy link
Member

jstrachan commented Dec 4, 2018

/retest

@jstrachan

This comment has been minimized.

Copy link
Member

jstrachan commented Dec 4, 2018

/test bdd

jstrachan added some commits Dec 4, 2018

fix: add retry around updating the PipelineActivity
in case we get concurrency issues with jx-resources plugin
chore: lets use a more specific path in case we share the git repo
e.g. to reuse 1 git repo for all test results across all projects
@pmuir

This comment has been minimized.

Copy link
Member

pmuir commented Dec 4, 2018

/lgtm

@jenkins-x-bot

This comment has been minimized.

Copy link
Contributor

jenkins-x-bot commented Dec 4, 2018

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: pmuir

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jenkins-x-bot jenkins-x-bot merged commit 4d80366 into jenkins-x:master Dec 4, 2018

2 of 3 checks passed

tide Not mergeable.
Details
Hound No violations found. Woof!
serverless-jenkins succeeded
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment