New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(teamcontroller): Do not panic when creating teams #2404

Merged
merged 1 commit into from Dec 4, 2018

Conversation

Projects
None yet
3 participants
@jtnord
Copy link
Member

jtnord commented Dec 4, 2018

Submitter checklist

  • Change is code complete and matches issue description.
  • Change is covered by existing or new tests.

Description

getDefaultAdminPassword(string) was expecting (incorrectly) that the
CahcedKubeClient has already been created wich was not correct.

change this to use KubeClient() which will create the cache if not
already done and return it if it has.

Special notes for the reviewer(s)

Which issue this PR fixes

fixes #2381

fix(#2381) Do not panic when creating teams
`getDefaultAdminPassword(string)` was expecting (incorrectly) that the
CahcedKubeClient has already been created wich was not correct.

change this to use `KubeClient()` which will create the cache if not
already done and return it if it has.

@jenkins-x-bot jenkins-x-bot requested review from ccojocar and wbrefvem Dec 4, 2018

@jtnord jtnord referenced this pull request Dec 4, 2018

Closed

chore() prevent external use of `KubeClientCached` #2405

2 of 2 tasks complete
@jstrachan

This comment has been minimized.

Copy link
Member

jstrachan commented Dec 4, 2018

/lgtm

@jenkins-x-bot

This comment has been minimized.

Copy link
Contributor

jenkins-x-bot commented Dec 4, 2018

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jstrachan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jstrachan

This comment has been minimized.

Copy link
Member

jstrachan commented Dec 4, 2018

/retest

@jenkins-x-bot jenkins-x-bot merged commit 37829b6 into jenkins-x:master Dec 4, 2018

3 checks passed

Hound No violations found. Woof!
serverless-jenkins succeeded
tide In merge pool.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment