New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(install): break the install command in smaller methods and make the cloud providers configuration more self contained #2417

Merged
merged 45 commits into from Dec 7, 2018

Conversation

@ccojocar
Copy link
Member

ccojocar commented Dec 5, 2018

Submitter checklist

  • Change is code complete and matches issue description.
  • Change is covered by existing or new tests.

Description

  • Breaks the install command in smaller methods in oder to understand the flow
  • Make the cloud provider configuration during the install more self contained in dedicated method
  • Extract the helm values configuration and helm values file creation
  • Separate the secrets files from helm values files
  • Extract the GitOps logic in separate method
  • Ensure that the GitOps secrets.yaml file is stored in Vault
  • Ensure that secrets.yaml is fetch from vault when environment chart is installed

Special notes for the reviewer(s)

Which issue this PR fixes

fixes #

@jenkins-x-bot jenkins-x-bot requested review from amuniz and jtnord Dec 5, 2018

@ccojocar ccojocar requested review from agentgonzo , jstrachan , rawlingsj and garethjevans and removed request for jtnord and amuniz Dec 5, 2018

@ccojocar ccojocar force-pushed the ccojocar:refactor-install branch from a88d524 to a482cc9 Dec 5, 2018

@agentgonzo
Copy link
Member

agentgonzo left a comment

looks good to me. A few minor points and questions, but this is a huge step towards maintainability. Deliberately not applying a label to allow others to comment

Show resolved Hide resolved pkg/jx/cmd/install.go
Show resolved Hide resolved pkg/jx/cmd/install.go Outdated
Show resolved Hide resolved pkg/jx/cmd/install.go
Show resolved Hide resolved pkg/jx/cmd/install.go
Show resolved Hide resolved pkg/jx/cmd/install.go
Show resolved Hide resolved pkg/jx/cmd/install.go
Show resolved Hide resolved pkg/jx/cmd/install.go Outdated
Show resolved Hide resolved pkg/jx/cmd/install.go Outdated
Show resolved Hide resolved pkg/jx/cmd/install.go Outdated
Show resolved Hide resolved pkg/jx/cmd/install.go Outdated

@ccojocar ccojocar force-pushed the ccojocar:refactor-install branch from 6c98903 to 578b2dc Dec 5, 2018

@jstrachan

This comment has been minimized.

Copy link
Member

jstrachan commented Dec 5, 2018

/lgtm

@ccojocar ccojocar force-pushed the ccojocar:refactor-install branch from 15f8595 to a738b79 Dec 5, 2018

@jenkins-x-bot jenkins-x-bot removed the lgtm label Dec 5, 2018

@ccojocar ccojocar force-pushed the ccojocar:refactor-install branch from a738b79 to 3887070 Dec 6, 2018

@ccojocar ccojocar referenced this pull request Dec 6, 2018

Closed

check release status before delete #2398

1 of 2 tasks complete

@ccojocar ccojocar force-pushed the ccojocar:refactor-install branch from d9a5465 to ae72752 Dec 6, 2018

@ccojocar ccojocar force-pushed the ccojocar:refactor-install branch from ae72752 to 986424f Dec 7, 2018

Show resolved Hide resolved pkg/vault/vault_client.go Outdated
Show resolved Hide resolved pkg/jx/cmd/install.go Outdated
Show resolved Hide resolved pkg/jx/cmd/install.go Outdated
Show resolved Hide resolved pkg/jx/cmd/install.go Outdated
Show resolved Hide resolved pkg/cloud/gke/gcloud.go Outdated
Show resolved Hide resolved pkg/cloud/gke/gcloud.go Outdated
Show resolved Hide resolved pkg/cloud/gke/gcloud.go Outdated
Show resolved Hide resolved pkg/cloud/gke/gcloud.go Outdated
Show resolved Hide resolved pkg/cloud/gke/gcloud.go Outdated
@ccojocar

This comment has been minimized.

Copy link
Member

ccojocar commented Dec 7, 2018

/lgtm

@jenkins-x-bot

This comment has been minimized.

Copy link
Contributor

jenkins-x-bot commented Dec 7, 2018

@ccojocar: you cannot LGTM your own PR.

In response to this:

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@jstrachan

This comment has been minimized.

Copy link
Member

jstrachan commented Dec 7, 2018

/lgtm

@jenkins-x-bot jenkins-x-bot added the lgtm label Dec 7, 2018

@jenkins-x-bot

This comment has been minimized.

Copy link
Contributor

jenkins-x-bot commented Dec 7, 2018

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ccojocar, jstrachan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ccojocar

This comment has been minimized.

Copy link
Member

ccojocar commented Dec 7, 2018

/test bdd

@jenkins-x-bot jenkins-x-bot merged commit e96abf5 into jenkins-x:master Dec 7, 2018

3 checks passed

Hound No violations found. Woof!
serverless-jenkins succeeded
tide In merge pool.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment