New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: if no options specified lets reuse the arguments #2425

Merged
merged 5 commits into from Dec 5, 2018

Conversation

Projects
None yet
3 participants
@jstrachan
Copy link
Member

jstrachan commented Dec 5, 2018

so that jx step helm apply works more like helm install releaseName dir

jstrachan added some commits Dec 5, 2018

fix: if no options specified lets reuse the arguments
so that `jx step helm apply` works more like `helm install releaseName dir`

@jenkins-x-bot jenkins-x-bot requested review from jtnord and mikecirioli Dec 5, 2018

@jenkins-x-bot jenkins-x-bot added the size/S label Dec 5, 2018

@jenkins-x-bot jenkins-x-bot added size/M and removed size/S labels Dec 5, 2018

@jtnord

This comment has been minimized.

Copy link
Member

jtnord commented Dec 5, 2018

/lgtm

@jenkins-x-bot

This comment has been minimized.

Copy link
Contributor

jenkins-x-bot commented Dec 5, 2018

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jtnord

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jenkins-x-bot jenkins-x-bot merged commit 26e9597 into jenkins-x:master Dec 5, 2018

2 checks passed

serverless-jenkins succeeded
tide In merge pool.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment