New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Provides a more reliable way to get the previous git tag sha #2441

Merged
merged 1 commit into from Dec 7, 2018

Conversation

@mikecirioli
Copy link
Member

mikecirioli commented Dec 6, 2018

Provides a more reliable way to get the previous git tag sha, even if there is only one tag defined on the branch. Previously this would cause the first build of a spring boot quickstart to fail on its first build

Submitter checklist

  • Change is code complete and matches issue description.
  • Change is covered by existing or new tests.

Description

This fix uses git describe to retrieve the sha of the previous git tag in the current branch.
example of the git commands being used:
newest=git describe --abbrev=0 --tags
git describe --always --abbrev=0 --tags $newest^

--always is used to handle the case when there is only a single tag defined

Special notes for the reviewer(s)

Which issue this PR fixes

fixes #2288

fix: Provides a more reliable way to get the previous git tag sha, ev…
…en if

there is only one tag defined on the branch.  Previously this would cause
the first build of a spring boot quickstart to fail on its first build

@jenkins-x-bot jenkins-x-bot requested review from amuniz and jtnord Dec 6, 2018

@jenkins-x-bot jenkins-x-bot added the size/S label Dec 6, 2018

@jstrachan

This comment has been minimized.

Copy link
Member

jstrachan commented Dec 7, 2018

/lgtm

@jenkins-x-bot

This comment has been minimized.

Copy link
Contributor

jenkins-x-bot commented Dec 7, 2018

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: agentgonzo, ccojocar, jstrachan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [agentgonzo,ccojocar,jstrachan]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@agentgonzo

This comment has been minimized.

Copy link
Member

agentgonzo commented Dec 7, 2018

/test bdd

@jenkins-x-bot jenkins-x-bot merged commit 23e1232 into jenkins-x:master Dec 7, 2018

2 checks passed

serverless-jenkins succeeded
tide In merge pool.
Details

@mikecirioli mikecirioli deleted the mikecirioli:springboot_fix branch Dec 7, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment